-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the generic setup method to distinguish better between the setup_schematisation and add data methods #475
Comments
In #534 the changes were first implemented by maybe the names should be discussed with users before changing for good to find which names would be more explicit. |
As it seems that this will take a bit longer, should we move this to Q4 then? |
More context
I'd be happy to hear the opinion of some users: @hboisgon @roeldegoede @JoostBuitink @xldeltares |
Hi @DirkEilander , thanks for asking and I recognize the necessity for the method names to be self-explanatory to reduce confusion for users and developers. |
Fixed in #671 |
Kind of request
Changing existing functionality
Enhancement Description
So far it's not too clear if the generic setup methods create a grid/mesh schematisation or add data to it.
We kind of have a convention than method name starts with setup_ so renaming would be for example setup_grid_data_from_geodataframe instead of setup_grid_from_geodataframe.
Use case
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: