Add support for T9 PLUS (um2ywg) #632
Conversation
|
Warning Rate limit exceeded@edenhaus has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 9 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe changes introduce a new file, Changes
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
deebot_client/hardware/deebot/um2ywg.py (3)
Line range hint
20-23: Optimize imports by removing unused onesReview the imported modules to ensure that all are necessary. Unused imports can clutter the code and potentially lead to maintenance issues.
Line range hint
44-57: Avoid duplication ofLifeSpantypesThe
LifeSpantypes are duplicated in both thetypesparameter and within theGetLifeSpancall. To improve maintainability, define the list once and reuse it.Apply this refactor:
# Define the list once life_span_types = [ LifeSpan.BRUSH, LifeSpan.FILTER, LifeSpan.SIDE_BRUSH, LifeSpan.UNIT_CARE, ] life_span=CapabilityLifeSpan( types=life_span_types, event=LifeSpanEvent, get=[GetLifeSpan(life_span_types)], reset=ResetLifeSpan, ),
Line range hint
81-83: Consider adding error handling for network capabilitiesWhen retrieving network information using
GetNetInfo(), consider adding error handling to manage potential exceptions if the device is offline or unreachable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
deebot_client/hardware/deebot/um2ywg.py(1 hunks)
🔇 Additional comments (4)
deebot_client/hardware/deebot/um2ywg.py (4)
Line range hint 59-75: Verify the empty command list in MapChangedEvent
The map.changed capability has an empty list of commands:
changed=CapabilityEvent(MapChangedEvent, []),Ensure that this is intentional and that no commands are required to trigger the MapChangedEvent.
Line range hint 87-99: Ensure consistency in CapabilitySetEnable usage
In the settings capabilities, verify that all CapabilitySetEnable instances correctly implement both the get and set methods. For example, advanced_mode, carpet_auto_fan_boost, and true_detect should consistently handle enabling and disabling features.
Line range hint 105-114: Confirm all WaterAmount levels are supported
The water capability includes various WaterAmount levels. Verify that the device supports all specified levels, especially WaterAmount.ULTRAHIGH, to prevent unsupported setting errors.
1-1:
Remove unintended code on line 1
Line 1 contains x5d34r.py, which appears to be unintended and could cause a syntax error. If this was meant to be a comment, please prefix it with #, or remove the line if it's unnecessary.
Apply this diff to fix the issue:
- x5d34r.pyLikely invalid or redundant comment.
|
FWIW confirmed this works |
Hi, thanks for feedback. I don't know because merge failed |
edenhaus
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #632 +/- ##
=======================================
Coverage 86.68% 86.68%
=======================================
Files 90 90
Lines 3365 3365
Branches 298 298
=======================================
Hits 2917 2917
Misses 394 394
Partials 54 54 ☔ View full report in Codecov by Sentry. |
edenhaus
changed the title
|
I just Updates to HA 2024.12.2 |
Hi, Marco |
Hey DEEBOT T9+ (lhbd50) |
Hi device Id is different from mine T9+ that is um2ywg This create a symlink to your robot using the T8 set of commands. Please perform a backup o a snapshot of your HA installation, you use these commands at your own risk. Marco |
Here is Pull request to add T9+ um2ywg to supported device.
Set of command are from T8 AIVI.
Summary by CodeRabbit