Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modals): Buttons position #99

Merged
merged 5 commits into from
Jun 20, 2023
Merged

fix(modals): Buttons position #99

merged 5 commits into from
Jun 20, 2023

Conversation

corentin-stamper
Copy link
Contributor

@corentin-stamper corentin-stamper commented Feb 3, 2023 •
edited
Loading

Changes description 🧑‍💻

  • fix modal buttons position
  • add paparazzi tests for modals

Context 🤔

Closes #82
Closes #88
Closes #115
Closes #116

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

@corentin-stamper corentin-stamper requested review from ManonPolle and a team as code owners February 3, 2023 15:34
@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/7b025a55-73b6-476c-ad14-59840742de1c/artifact/881e64456e079a30/p/09916dec744020bbba39dfa3e6bfcdcd

@lauthieb lauthieb added bug 🐛 Something isn't working run 💨 labels Feb 9, 2023
@corentin-stamper corentin-stamper requested review from a team February 24, 2023 15:32
@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/1c613f77-fff3-4c25-8d65-e2328e232ccf/artifact/75c204f0abbae497/p/4849bf574602f40fd854aee13af3dc98

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/bc7e7897-44a5-45b7-8a6c-cf6e4f2614c2/artifact/36697f8babeae741/p/ccc0134bbdcefc376bfece21b3e2137d

@corentin-stamper corentin-stamper force-pushed the issue/82 branch 2 times, most recently from d75f321 to 9ecc9cd Compare March 3, 2023 15:51
FDELAHA24
FDELAHA24 previously approved these changes Mar 3, 2023
View reviewed changes
modals/README.md Outdated Show resolved Hide resolved
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/25fa0917-a117-4945-b3fa-796964493cfa/artifact/7b3017a24b090036/p/b07db4d72dcc86b7a9df705b3ba6ce77

@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/a2d60035-5f58-4179-bbc3-d82607912576/artifact/37ec0f17d4a7e377/p/16dc9d0e2eb427347828e071b8cfd2e0

GerardPaligot
GerardPaligot requested changes May 11, 2023
View reviewed changes
modals/README.md Outdated Show resolved Hide resolved
modals/README.md Outdated Show resolved Hide resolved
modals/README.md Outdated Show resolved Hide resolved
modals/README.md Show resolved Hide resolved
modals/README.md Outdated Show resolved Hide resolved
modals/src/main/java/com/decathlon/vitamin/compose/modals/VitaminModals.kt Show resolved Hide resolved
modals/src/main/java/com/decathlon/vitamin/compose/modals/VitaminModals.kt Outdated Show resolved Hide resolved
modals/src/main/java/com/decathlon/vitamin/compose/modals/impl/ModalButtons.kt Outdated Show resolved Hide resolved
modals/src/main/java/com/decathlon/vitamin/compose/modals/impl/ModalButtons.kt Outdated Show resolved Hide resolved
modals/src/main/java/com/decathlon/vitamin/compose/modals/impl/VitaminModalImpl.kt Outdated Show resolved Hide resolved
@corentin-stamper corentin-stamper force-pushed the issue/82 branch 2 times, most recently from dcf932c to fd3f3ef Compare May 17, 2023 06:12
@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/6a500604-2369-46ed-ad8e-b21608dc299c/artifact/d73a57247d30eba8/p/2df7ff8672c8ebbe59622d05a955d596

GerardPaligot
GerardPaligot requested changes May 17, 2023
View reviewed changes
modals/README.md Outdated Show resolved Hide resolved
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/8a2790ba-4c65-4ec2-8558-67d1655da30c/artifact/6a795e1086d513fa/p/6fad8ee2b52f4fb57ec167b5fb70432a

GerardPaligot
GerardPaligot previously approved these changes May 23, 2023
View reviewed changes
ManonPolle
ManonPolle previously approved these changes May 25, 2023
View reviewed changes
@corentin-stamper corentin-stamper dismissed stale reviews from ManonPolle and GerardPaligot via fd37cdb May 26, 2023 12:48
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/4e1f7c31-d78a-49ef-bdd6-f0bd0d47fdd0/artifact/0652abec811447b5/p/6584609b8e553a2208e77b89caad10b2

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/829328ec-05c8-442b-acee-833ccc36408b/artifact/da718c9410cd4f04/p/28f3388cbb51c3ab6a5aad12e9bf8ab3

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/39f2eed8-eaba-4b18-a996-c823c475c37e/artifact/056ef7b0178f54b3/p/aa0fc5628c6fd059297dd257b61ad001

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/7502b183-2e93-4b59-a1bd-383d598bcbb5/artifact/e64f52e9f1d05aba/p/779cb8764e303173b2fbe1efba66c451

@ManonPolle ManonPolle merged commit 0b9b694 into Decathlon:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

@FDELAHA24 FDELAHA24 FDELAHA24 left review comments

@GerardPaligot GerardPaligot GerardPaligot left review comments

Assignees

@corentin-stamper corentin-stamper

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
6 participants
@corentin-stamper @dktbitrise @GerardPaligot @ManonPolle @FDELAHA24 @lauthieb