Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(modal): Add paparazzi tests #88

Closed
ManonPolle opened this issue Feb 3, 2023 · 0 comments · Fixed by #99
Closed

test(modal): Add paparazzi tests #88

ManonPolle opened this issue Feb 3, 2023 · 0 comments · Fixed by #99
Assignees
@corentin-stamper
Labels
community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community enhancement 🚀 New feature or request
Milestone
0.3.0

Comments

@ManonPolle
Copy link
Contributor

Describe the solution you'd like
Write tests with paparazzi for modal component for all variants & themes.

Additional context
FYI Buttons already have ones.
@ManonPolle ManonPolle added enhancement 🚀 New feature or request run 💨 labels Feb 3, 2023
@ManonPolle ManonPolle moved this from 🆕 New to 🔖 Dev to do in Decathlon Design System Feb 3, 2023
@corentin-stamper corentin-stamper self-assigned this Feb 3, 2023
@corentin-stamper corentin-stamper moved this from 🔖 Dev to do to 💻 Dev in progress in Decathlon Design System Feb 3, 2023
@corentin-stamper corentin-stamper mentioned this issue Feb 3, 2023
Merged
9 tasks
@ManonPolle ManonPolle changed the title feat(modal): Add paparazzi tests test(modal): Add paparazzi tests Feb 3, 2023
@corentin-stamper corentin-stamper moved this from 💻 Dev in progress to 👀 Dev review in Decathlon Design System Feb 3, 2023
@corentin-stamper corentin-stamper moved this from 👀 Dev review to 💻 Dev in progress in Decathlon Design System Feb 9, 2023
@corentin-stamper corentin-stamper moved this from 💻 Dev in progress to 👀 Dev review in Decathlon Design System Feb 24, 2023
@corentin-stamper corentin-stamper moved this from 👀 Dev review to 💻 Dev in progress in Decathlon Design System Feb 24, 2023
@corentin-stamper corentin-stamper moved this from 💻 Dev in progress to 👀 Dev review in Decathlon Design System Feb 24, 2023
@ManonPolle ManonPolle added this to the 0.3.0 milestone Mar 16, 2023
@lauthieb lauthieb added the community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community label Mar 24, 2023
@lauthieb lauthieb removed the run 💨 label Apr 7, 2023
@github-project-automation github-project-automation bot moved this from 👀 Dev review to ✅ Done in Decathlon Design System Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corentin-stamper corentin-stamper

Labels
community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community enhancement 🚀 New feature or request
Projects
Decathlon Design System
Archived in project
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

fix(modals): Buttons position corentin-stamper/vitamin-compose
3 participants
@lauthieb @corentin-stamper @ManonPolle