This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
Unicode support by Yuki #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It supports conversion (test level)
It supports conversion (test level)
Test level source for unicode support
it will be removed before final commit to master branch
TCLAP Support
Unicode support
remove bat files
Unicode yuki
This reverts commit 2c1270a.
Unicode yuki
Modularized convert routine
remove unreachable codes.
DeadSix27
approved these changes
Jan 3, 2019
|
Works fine on my end, thanks for this :) (sorry that the review too so long, holidays in between..) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, we have Unicode support for windows. Check: #1, #4
I think this branch is ready to merge into master.
Feel free to test and notice me whether all functions works fine or not.
Test environments>
Main (Win 10): Intel i7-4770K / Radeon R9 280X
Notebook (Win 10): Intel i5-6200U / NVIDIA GTX 940MX
Sub (Win 10): Intel i3-3220 / HD Graphics
Linux (Ubuntu 18.04.1 LTS): Intel Xeon E5-2676 v3