Skip to content
This repository has been archived by the owner on Jun 2, 2022. It is now read-only.

Add image detection without extension? #3

Closed
DeadSix27 opened this issue Jan 2, 2017 · 4 comments
Closed

Add image detection without extension? #3

DeadSix27 opened this issue Jan 2, 2017 · 4 comments

Comments

@DeadSix27
Copy link
Owner

The program crashes when no image extension is given.
Maybe we can add code to auto-detect the image type?
Or error out if that is too much work and or is too unreliable.

Also in todo list: #1

@max20091
Copy link

max20091 commented Jan 2, 2017

We don't need a auto-detect image, just make a batch file and it will auto convert all images.

FOR /f "delims=" %%a IN ('dir /b input\*.*') DO call waifu2x-converter-cpp.exe --scale_ratio 2 --model_dir models_rgb\ -m noise_scale --noise_level 3 -i "input\%%a" -o "output\%%~na.png"

Currently supported image type is png, jpg and jpeg. I dunno if it support other image types.

  1. Make a input folder and a output folder
  2. Put some images to input folder
  3. Run the batch file

@DeadSix27
Copy link
Owner Author

I mean files without an extension in the input.
It just crashes the program, definitely needs a fix, its not hard to do,ill add that later.

@YukihoAA
Copy link
Collaborator

@DeadSix27 I created new Pull Request #14 to fix this issue.

DeadSix27 added a commit that referenced this issue Jul 17, 2017
@DeadSix27
Copy link
Owner Author

@YukihoAA merged your change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants