Add pagination support for listgovproposalvotes
#1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents optional arguments from becoming mandatory if pagination has to be set
shohamc1
requested review from
Bushstar,
Mixa84,
wafflespeanut,
prasannavl and
Jouzo
as code owners
dcorral
reviewed
Dec 7, 2022
There was a problem hiding this comment.
This will filter current cycle of the proposal which is internal to the proposal. We will need some mechanism to filter by global cycle meaning "get all proposals in the Nth voting round". Have a look at #1627 for a WIP implementation of this filter.
A suggestion was made to call this two filters differently:
- global cycle filter -> batch
- internal cycle -> cycle
UPDATE: This will apply for listgovproposals filtering, current implementation for listgovproposalvotes is actually valid.
shohamc1
changed the title
listgovproposalvoteslistgovproposalvotes
Mixa84
previously approved these changes
Dec 28, 2022
Mixa84
approved these changes
Dec 28, 2022
Jouzo
approved these changes
Dec 28, 2022
Mixa84
added a commit
that referenced
this pull request
Dec 30, 2022
Co-authored-by: Jouzo <15011228+Jouzo@users.noreply.github.com>
prasannavl
added a commit
that referenced
this pull request
Jan 5, 2023
* Add cycle filtering to listgovproposals * Fix cycle param description * Remove unused variable retMap * Replace uint with unsigned int to fix windows compile error * Add tests to listgovproposals * Removes trailing whitespaces and unused imports * Fix ForEachCycleProp returning early * Add pagination to listgovproposal * Fix lint * Format src/masternodes/rpc_proposals.cpp * Pagination nesting as in #1635 Co-authored-by: Jouzo <15011228+Jouzo@users.noreply.github.com> * Make pagination rpc consistent * Resolve compiler warning * Update help message Co-authored-by: Keng Ye <40191153+kyleleow@users.noreply.github.com> Co-authored-by: jouzo <jdesclercs@gmail.com> Co-authored-by: Jouzo <15011228+Jouzo@users.noreply.github.com> Co-authored-by: Mihailo Milenkovic <mihailo.milenkovic84@gmail.com> Co-authored-by: Peter John Bushnell <bushsolo@gmail.com> Co-authored-by: Prasanna Loganathar <pvl@prasannavl.com> Co-authored-by: Keng Ye <40191153+kyleleow@users.noreply.github.com>
fuxingloh
pushed a commit
to DeFiCh/jellyfishsdk
that referenced
this pull request
Jan 11, 2023
<!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: - Update listGovProposalVotes arguments as per DeFiCh/ain#1635. This is required to keep compatibility with the next release. Signed-off-by: Shoham Chakraborty <shhmchk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Provides pagination support for the
listgovproposalvotesRPC.Pagination arguments can be provided via the
paginationCLI argument.If you do not want to set the RPC's optional arguments, users can pass arguments via an object instead.
$ defi-cli listgovproposalvotes '{"proposalId": "propId", "pagination": {"limit": 2}}'There are three pagination arguments available:
start: Index of the first entry to return. Usuallystart + limitof the previous call.including_start: To include first entry of the results. This is set tofalseifstarthas been set.limit: Maximum number of entries to return in one RPC call.Successive pagination calls would look like: