Add cycle filtering and pagination to listgovproposals #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcorral
requested review from
Bushstar,
Mixa84,
wafflespeanut,
prasannavl and
Jouzo
as code owners
Mixa84
previously approved these changes
Dec 5, 2022
…o feature/add-cycle-filter-listgovproposals
Jouzo
force-pushed
the
feature/add-cycle-filter-listgovproposals
branch
from
9fc8b37 to
e6a52dc
Compare
…m:DeFiCh/ain into feature/add-cycle-filter-listgovproposals
dcorral
commented
Dec 19, 2022
Mixa84
previously approved these changes
Dec 19, 2022
Mixa84
previously approved these changes
Dec 28, 2022
Jouzo
previously approved these changes
Dec 28, 2022
Jouzo
reviewed
Dec 30, 2022
Jouzo
reviewed
Dec 30, 2022
Co-authored-by: Jouzo <15011228+Jouzo@users.noreply.github.com>
Jouzo
previously approved these changes
Dec 30, 2022
kyleleow
reviewed
Jan 5, 2023
Co-authored-by: Keng Ye <40191153+kyleleow@users.noreply.github.com>
Jouzo
changed the title
Jouzo
approved these changes
Jan 5, 2023
fuxingloh
pushed a commit
to DeFiCh/jellyfishsdk
that referenced
this pull request
Jan 12, 2023
…and pagination (#1954) <!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: - To update `listGovProposals` to accept `cycle` and `pagination` added in DeFiCh/ain#1627 - To add more e2e related to `pagination` #### Which issue(s) does this PR fixes?: <!-- (Optional) Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes # #### Additional comments?: - Pending DeFiCh/ain#1689 to fix an issue where `start` is ignored when `status` is not passed OR when `cycle` is passed - However, this should not be a blocker for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Adds cycle filtering in
listgovproposalsRPCAdds pagination to
listgovproposalsRPC :Pagination arguments can be provided via the pagination CLI argument.
If you do not want to set the RPC's optional arguments, users can pass arguments via an object instead.