Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump eslint-plugin-ember from 11.11.1 to 12.0.0 #337

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
"ember-try": "^3.0.0",
"eslint": "^8.52.0",
"eslint-config-prettier": "^9.0.0",
"eslint-plugin-ember": "^11.11.1",
"eslint-plugin-ember": "^12.0.0",
"eslint-plugin-n": "^16.2.0",
"eslint-plugin-prettier": "^5.0.1",
"eslint-plugin-qunit": "^8.0.1",
Expand Down
3 changes: 1 addition & 2 deletions tests/unit/initializers/embedded-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import Application from '@ember/application'
import { initialize } from 'dummy/initializers/embedded'
import { module, test } from 'qunit'
import Resolver from 'ember-resolver'
import { run } from '@ember/runloop'

type TestApplication = Application & {
// Public types are currently incomplete, these 2 properties exist:
Expand Down Expand Up @@ -43,7 +42,7 @@ module('Unit | Initializer | embedded', function (hooks) {
})

hooks.afterEach(function (this: Context) {
run(this.application, 'destroy')
this.application.destroy()
})

test('by default, it does not change the normal behaviour', async function (this: Context, assert) {
Expand Down
3 changes: 1 addition & 2 deletions tests/unit/initializers/export-application-global-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { initialize } from 'dummy/initializers/export-application-global'
import { module, test } from 'qunit'
import Resolver from 'ember-resolver'
import { classify } from '@ember/string'
import { run } from '@ember/runloop'

import type AppConfig from 'dummy/config/environment'

Expand Down Expand Up @@ -51,7 +50,7 @@ module('Unit | Initializer | export-application-global', function (hooks) {
// @ts-expect-error: No index signature for Window
delete window[exportedApplicationGlobal]

run(this.application, 'destroy')
this.application.destroy()
})

const testCases = [
Expand Down
5 changes: 2 additions & 3 deletions tests/unit/instance-initializers/embedded-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import Application from '@ember/application'
import { initialize } from 'dummy/instance-initializers/embedded'
import { module, test } from 'qunit'
import Resolver from 'ember-resolver'
import { run } from '@ember/runloop'

import type { TestContext } from '@ember/test-helpers'
import type ApplicationInstance from '@ember/application/instance'
Expand Down Expand Up @@ -34,8 +33,8 @@ module('Unit | Instance Initializer | embedded', function (hooks) {
})

hooks.afterEach(function (this: Context) {
run(this.appInstance, 'destroy')
run(this.application, 'destroy')
this.appInstance.destroy()
this.application.destroy()
})

test('It works when `embedded` config is not defined', async function (this: Context, assert) {
Expand Down
Loading
Loading