Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump eslint-plugin-ember from 11.11.1 to 12.0.0 #337

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 2, 2024

Bumps eslint-plugin-ember from 11.11.1 to 12.0.0.

Release notes

Sourced from eslint-plugin-ember's releases.

Release 12.0.0

💥 Breaking Change

🚀 Enhancement

🐛 Bug Fix

📝 Documentation

🏠 Internal

Committers: 4

... (truncated)

Changelog

Sourced from eslint-plugin-ember's changelog.

v12.0.0 (2024-01-13)

💥 Breaking Change

🚀 Enhancement

🐛 Bug Fix

📝 Documentation

🏠 Internal

Committers: 4

... (truncated)

Commits
  • e6d2802 Release 12.0.0
  • 2650be0 Bump ember-eslint-parser to 0.2.5 - Includes fix for SVG scope parsing (#2055)
  • e89c14f Bump minimum version of ember-eslint-parser to 0.2.4 (#2048)
  • dff635a Fix issue with no-deprecated-router-transition-methods throwing errors outs...
  • 6b0b522 Remove unused dependency; @​glimmer/syntax (#2047)
  • b2b956f Upgrade ember-eslint-parser (#2045)
  • 8dfa9a3 Update all dependencies (#2042)
  • 561befc Release 12.0.0-alpha.4
  • cdf76ba build(deps): Bump github/codeql-action from 2 to 3 (#2031)
  • ca54d94 Move gjs/gts parser to ember-eslint-parser library (#2028)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner February 2, 2024 23:47
@dependabot dependabot bot added the dependencies Changes that update dependencies label Feb 2, 2024
@MrChocolatine MrChocolatine marked this pull request as draft February 3, 2024 19:55
@MrChocolatine
Copy link
Member

@dependabot rebase

Bumps [eslint-plugin-ember](https://github.com/ember-cli/eslint-plugin-ember) from 11.11.1 to 12.0.0.
- [Release notes](https://github.com/ember-cli/eslint-plugin-ember/releases)
- [Changelog](https://github.com/ember-cli/eslint-plugin-ember/blob/master/CHANGELOG.md)
- [Commits](ember-cli/eslint-plugin-ember@v11.11.1...v12.0.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-ember
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot-npm_and_yarn-eslint-plugin-ember-12.0.0 branch from 93213fe to 1ec0ba7 Compare February 3, 2024 19:56
@MrChocolatine MrChocolatine marked this pull request as ready for review February 15, 2024 18:02
@MrChocolatine MrChocolatine self-assigned this Feb 15, 2024
@MrChocolatine
Copy link
Member

Not 100% sure of my changes but it works.

I simply removed the use of @ember/runloop and called the destroy method of the objects directly.

@MrChocolatine MrChocolatine merged commit a51ae49 into master Feb 15, 2024
9 checks passed
@MrChocolatine MrChocolatine deleted the dependabot-npm_and_yarn-eslint-plugin-ember-12.0.0 branch February 15, 2024 18:06
@MrChocolatine MrChocolatine mentioned this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that update dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant