Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_service_level_objectives] Fix test flakiness #2162

Merged
merged 3 commits into from
Oct 31, 2023
Merged

[datadog_service_level_objectives] Fix test flakiness #2162

merged 3 commits into from
Oct 31, 2023

Conversation

nkzou
Copy link
Contributor

@nkzou nkzou commented Oct 27, 2023

two issues:

  1. The SLO destroy helper didn't check if the resource id it was using was a SLO resource, so it was sometimes trying to delete using a datasource id.
  2. It also exits after the first deleted SLO, so the datasource tests that create two will fail because it's random which one gets deleted.

@nkzou nkzou requested a review from a team as a code owner October 27, 2023 20:28
@nkzou nkzou merged commit 68ac174 into master Oct 31, 2023
8 checks passed
@nkzou nkzou deleted the kevinzou/slos_fixed_order branch October 31, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skarimo skarimo skarimo approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkzou @skarimo