[datadog_service_level_objectives] Fix test flakiness (#2162)

* fix slo destroy helper to only delete slo resources, and also delete all slo resources

* rerecord because new

* remove second name since it was always the same as the first name

datadog/tests/cassettes/TestAccDatadogServiceLevelObjectiveDatasource.freeze

@@ -1 +1 @@
-2023-01-12T12:48:42.231916-05:00
+2023-10-27T16:33:32.381688-04:00

datadog/tests/cassettes/TestAccDatadogServiceLevelObjectivesDatasource.freeze

@@ -1 +1 @@
-2023-01-12T12:49:48.543499-05:00
+2023-10-27T16:19:33.207655-04:00

datadog/tests/data_source_datadog_service_level_objectives_test.go

@@ -13,8 +13,7 @@ import (
 func TestAccDatadogServiceLevelObjectivesDatasource(t *testing.T) {
 	t.Parallel()
 	ctx, accProviders := testAccProviders(context.Background(), t)
-	firstSLOName := strings.ToLower(strings.ReplaceAll(uniqueEntityName(ctx, t), "-", "_"))
-	secondSLOName := strings.ToLower(strings.ReplaceAll(uniqueEntityName(ctx, t), "-", "_"))
+	sloName := strings.ToLower(strings.ReplaceAll(uniqueEntityName(ctx, t), "-", "_"))
 	accProvider := testAccProvider(t, accProviders)
 
 	resource.Test(t, resource.TestCase{
@@ -23,20 +22,20 @@ func TestAccDatadogServiceLevelObjectivesDatasource(t *testing.T) {
 		CheckDestroy:      testAccCheckDatadogServiceLevelObjectiveDestroy(accProvider),
 		Steps: []resource.TestStep{
 			{
-				Config: testAccDatasourceServiceLevelObjectivesIdsConfig(firstSLOName),
-				Check:  checkServiceLevelObjectivesSingleResultDatasourceAttrs(accProvider, firstSLOName),
+				Config: testAccDatasourceServiceLevelObjectivesIdsConfig(sloName),
+				Check:  checkServiceLevelObjectivesSingleResultDatasourceAttrs(accProvider, sloName),
 			},
 			{
-				Config: testAccDatasourceServiceLevelObjectivesNameFilterConfig(firstSLOName, secondSLOName),
-				Check:  checkServiceLevelObjectivesSingleResultDatasourceAttrs(accProvider, firstSLOName),
+				Config: testAccDatasourceServiceLevelObjectivesNameFilterConfig(sloName),
+				Check:  checkServiceLevelObjectivesSingleResultDatasourceAttrs(accProvider, sloName),
 			},
 			{
-				Config: testAccDatasourceServiceLevelObjectivesTagsFilterConfig(firstSLOName),
-				Check:  checkServiceLevelObjectivesMultipleResultsDatasourceAttrs(accProvider, firstSLOName),
+				Config: testAccDatasourceServiceLevelObjectivesTagsFilterConfig(sloName),
+				Check:  checkServiceLevelObjectivesMultipleResultsDatasourceAttrs(accProvider, sloName),
 			},
 			{
-				Config: testAccDatasourceServiceLevelObjectivesMetricsFilterConfig(firstSLOName),
-				Check:  checkServiceLevelObjectivesMultipleResultsDatasourceAttrs(accProvider, firstSLOName),
+				Config: testAccDatasourceServiceLevelObjectivesMetricsFilterConfig(sloName),
+				Check:  checkServiceLevelObjectivesMultipleResultsDatasourceAttrs(accProvider, sloName),
 			},
 		},
 	})
@@ -112,7 +111,7 @@ data "datadog_service_level_objectives" "foo" {
 	)
 }
 
-func testAccDatasourceServiceLevelObjectivesNameFilterConfig(firstSLOName string, secondSLOName string) string {
+func testAccDatasourceServiceLevelObjectivesNameFilterConfig(sloName string) string {
 	return fmt.Sprintf(`
 %s
 %s
@@ -124,9 +123,9 @@ data "datadog_service_level_objectives" "foo" {
   name_query = "%s"
 }
 `,
-		testAccCheckDatadogServiceLevelObjectiveUniqueTagMetricConfig(firstSLOName),
-		strings.ReplaceAll(testAccCheckDatadogServiceLevelObjectiveUniqueTagMetricConfig(secondSLOName), "\"foo\"", "\"bar\""),
-		firstSLOName,
+		testAccCheckDatadogServiceLevelObjectiveUniqueTagMetricConfig(sloName),
+		strings.ReplaceAll(testAccCheckDatadogServiceLevelObjectiveUniqueTagMetricConfig(sloName), "\"foo\"", "\"bar\""),
+		sloName,
 	)
 }
 

datadog/tests/resource_datadog_service_level_objective_test.go

@@ -264,10 +264,10 @@ func testAccCheckDatadogServiceLevelObjectiveDestroy(accProvider func() (*schema
 func destroyServiceLevelObjectiveHelper(ctx context.Context, s *terraform.State, apiInstances *utils.ApiInstances) error {
 	err := utils.Retry(2, 5, func() error {
 		for _, r := range s.RootModule().Resources {
-			if r.Primary.ID != "" {
+			if r.Primary.ID != "" && r.Type == "datadog_service_level_objective" {
 				if _, httpResp, err := apiInstances.GetServiceLevelObjectivesApiV1().GetSLO(ctx, r.Primary.ID); err != nil {
 					if httpResp != nil && httpResp.StatusCode == 404 {
-						return nil
+						continue
 					}
 					return &utils.FatalError{Prob: fmt.Sprintf("received an error retrieving service level objective %s", err)}
 				}