-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sva91/ECI-399 E2E logs private beta update stack #36
Merged
sva91
merged 5 commits into
sva91/eci-398-add-connector-hub
from
sva91/eci-399-e2e-logs-private-beta
Feb 5, 2025
Merged
Sva91/ECI-399 E2E logs private beta update stack #36
sva91
merged 5 commits into
sva91/eci-398-add-connector-hub
from
sva91/eci-399-e2e-logs-private-beta
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengillmandd
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a bunch of nit ⛏️ s Given I'm not super familiar with terraform, might be good to get kanishk's review here too
sva91
added a commit
that referenced
this pull request
Feb 5, 2025
* ECI-398 Add connectorhub module * fix bugs * simplify audit log input * uncomment modules * Sva91/ECI-399 E2E logs private beta update stack (#36) * modify as per updated requirements * remove resource prefix from policy * fix bug * fix login issue * Reviewer comments ECI-399 * Reviewer comments
sva91
added a commit
that referenced
this pull request
Feb 5, 2025
* prepare tuples for log forwarding * Testing Issues resolution * uncomment code * rename data variable * move log search outside compartment in logging module * update output * simplify resource creation * Sva91/eci 397 handle audit log configs (#32) * ECI-397 Add Audit Log Forwarding * Uncomment audit log name * reviewer comment * ECI-398 Add connectorhub module (#35) * ECI-398 Add connectorhub module * fix bugs * simplify audit log input * uncomment modules * Sva91/ECI-399 E2E logs private beta update stack (#36) * modify as per updated requirements * remove resource prefix from policy * fix bug * fix login issue * Reviewer comments ECI-399 * Reviewer comments * reviewer comments ECI-396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Testing