Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sva91/ECI-399 E2E logs private beta update stack #36

Merged

Conversation

sva91
Copy link
Contributor

@sva91 sva91 commented Feb 3, 2025

What

  • Replace exclude_services with include_services
  • Replace CSV Upload for compartments with Comma separated values for compartments to align with the current metrics experience
  • Update Docker inputs to align with the current metrics experience
  • Remove Function Shape variable to align with current metrics experience

Why

  • Prepare for Private Beta Launch for Logs

Testing

@sva91 sva91 changed the base branch from master to sva91/eci-397-handle-audit-log-configs February 3, 2025 20:56
@sva91 sva91 changed the base branch from sva91/eci-397-handle-audit-log-configs to sva91/eci-398-add-connector-hub February 3, 2025 20:58
@sva91 sva91 added the eci label Feb 3, 2025
@sva91 sva91 marked this pull request as ready for review February 3, 2025 21:24
@sva91 sva91 changed the title Sva91/eci 399 e2e logs private beta Sva91/ECI-399 E2E logs private beta update stack Feb 3, 2025
Copy link
Contributor

@bengillmandd bengillmandd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bunch of nit ⛏️ s Given I'm not super familiar with terraform, might be good to get kanishk's review here too

@sva91 sva91 merged commit f3b79f2 into sva91/eci-398-add-connector-hub Feb 5, 2025
sva91 added a commit that referenced this pull request Feb 5, 2025
* ECI-398 Add connectorhub module

* fix bugs

* simplify audit log input

* uncomment modules

* Sva91/ECI-399 E2E logs private beta update stack (#36)

* modify as per updated requirements

* remove resource prefix from policy

* fix bug

* fix login issue

* Reviewer comments
ECI-399

* Reviewer comments
sva91 added a commit that referenced this pull request Feb 5, 2025
* prepare tuples for log forwarding

* Testing Issues resolution

* uncomment code

* rename data variable

* move log search outside compartment in logging module

* update output

* simplify resource creation

* Sva91/eci 397 handle audit log configs (#32)

* ECI-397 Add Audit Log Forwarding

* Uncomment audit log name

* reviewer comment

* ECI-398 Add connectorhub module (#35)

* ECI-398 Add connectorhub module

* fix bugs

* simplify audit log input

* uncomment modules

* Sva91/ECI-399 E2E logs private beta update stack (#36)

* modify as per updated requirements

* remove resource prefix from policy

* fix bug

* fix login issue

* Reviewer comments
ECI-399

* Reviewer comments

* reviewer comments
ECI-396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants