-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECI-396] Add logging module #31
[ECI-396] Add logging module #31
Conversation
* ECI-397 Add Audit Log Forwarding * Uncomment audit log name * reviewer comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a couple of nitpicks. I'm not the best person to review this so might be good to get Kanishk's review too
@@ -0,0 +1,35 @@ | |||
resource "oci_logging_log_group" "datadog_service_log_group" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This exists already for audit logs yeah? That is why we don't need to create this for audit logs too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's correct. Audit Log group for a compartment is created when the compartment itself is created.
* ECI-398 Add connectorhub module * fix bugs * simplify audit log input * uncomment modules * Sva91/ECI-399 E2E logs private beta update stack (#36) * modify as per updated requirements * remove resource prefix from policy * fix bug * fix login issue * Reviewer comments ECI-399 * Reviewer comments
What
Why
Testing
Issues Fixed During Testing