Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Service Level Objectives #5542

Merged
merged 17 commits into from
Oct 16, 2019
Merged

Add documentation for Service Level Objectives #5542

merged 17 commits into from
Oct 16, 2019

Conversation

platinummonkey
Copy link
Contributor

@platinummonkey platinummonkey commented Sep 30, 2019 •
edited by apigirl
Loading

@platinummonkey
add service level objectives MA-434
ff23c12 
initial commit

need to update some sections and ordering
@platinummonkey
Copy link
Contributor Author

platinummonkey commented Sep 30, 2019 •
edited by l0k0ms
Loading

TODO:

  • needs icons
  • needs re-ordering of /api docs (is there a tool for this?)

@platinummonkey platinummonkey marked this pull request as ready for review September 30, 2019 21:51
@platinummonkey platinummonkey requested a review from a team as a code owner September 30, 2019 21:51
@l0k0ms l0k0ms added the monitors Content changed in the monitors folder label Oct 1, 2019
@l0k0ms
Copy link
Contributor

l0k0ms commented Oct 1, 2019

@platinummonkey I fixed the API behavior + added placeholders for PY and RB code examples.

@platinummonkey
Copy link
Contributor Author

related: datadogpy PR DataDog/datadogpy#453

@platinummonkey
Copy link
Contributor Author

related: dogapi-rb PR DataDog/dogapi-rb#188

@meghanelizabeth
Copy link
Contributor

assuming this is the required icon? https://cl.ly/997f18ab3796

@meghanelizabeth
Copy link
Contributor

This is blank https://docs-staging.datadoghq.com/cody/service-level-objectives/api/?lang=bash#get-a-service-level-objective-s-details

meghanelizabeth
meghanelizabeth suggested changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@meghanelizabeth meghanelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs-staging.datadoghq.com/cody/service-level-objectives/api/?lang=bash#get-a-service-level-objective-s-details

@platinummonkey
Copy link
Contributor Author

should be fixed @meghanelizabeth also doc team is going to remerge back to a sub of monitors

apigirl
apigirl reviewed Oct 1, 2019
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review @meghanelizabeth

@apigirl apigirl added the WORK IN PROGRESS No review needed, it's a wip ;) label Oct 1, 2019
platinummonkey
platinummonkey commented Oct 3, 2019
View reviewed changes
Copy link
Contributor Author

@platinummonkey platinummonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add additional links back to the API docs?

@platinummonkey
Copy link
Contributor Author

bump @apigirl can we get this finalized for release?

@apigirl apigirl removed the WORK IN PROGRESS No review needed, it's a wip ;) label Oct 16, 2019
@apigirl apigirl merged commit 7b84d33 into master Oct 16, 2019
@apigirl apigirl deleted the cody/service-level-objectives branch October 16, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apigirl apigirl apigirl approved these changes

@meghanelizabeth meghanelizabeth meghanelizabeth approved these changes

Assignees
No one assigned
Labels
monitors Content changed in the monitors folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@platinummonkey @l0k0ms @meghanelizabeth @apigirl