-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for SLOs #453
add support for SLOs #453
Conversation
/azp run DataDog.datadogpy.integration |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run DataDog.datadogpy.integration |
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
/azp run DataDog.datadogpy.integration |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run DataDog.datadogpy.integration |
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
/azp run DataDog.datadogpy.integration |
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
/azp run DataDog.datadogpy.integration |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run DataDog.datadogpy.integration |
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
/azp run DataDog.datadogpy.integration |
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
/azp run DataDog.datadogpy.integration |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Also, it might be worth it adding some dogshell tests as well
/azp run DataDog.datadogpy.integration |
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
/azp run DataDog.datadogpy.integration |
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
/azp run DataDog.datadogpy.integration |
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
/azp run DataDog.datadogpy.integration |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run DataDog.datadogpy.integration |
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
/azp run DataDog.datadogpy.integration |
Azure Pipelines successfully started running 1 pipeline(s). |
this makes dogshell UX better
/azp run DataDog.datadogpy.integration |
Azure Pipelines successfully started running 1 pipeline(s). |
…nings-style errors for certain status codes update SLO tests
/azp run DataDog.datadogpy.integration |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we test for some error scenarios here please 🙏 ?
/azp run DataDog.datadogpy.integration |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !! Thanks a lot for all this
* add support for SLOs * add suppress ApiError on base client for status codes to adapt to warnings-style errors for certain status codes * add test for core client suppression * compat for py3 * helper hack for py3 testing compat
* add support for SLOs * add suppress ApiError on base client for status codes to adapt to warnings-style errors for certain status codes * add test for core client suppression * compat for py3 * helper hack for py3 testing compat
Adds support for Service Level Objectives
MA-434