You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an earlier version of my PR to reduce allocation event size, I was passing a callback to save_context to reserve size in ring buffer. function_ref allowed to pass a capturing lambda without the extra cost associated to std::function.
Since I changed my implementation, I do not need this anymore, I changed the PR status to draft.
Base automatically changed from
nsavoire/remove_dependencies_on_ddprof_parser to
mainOctober 26, 2023 20:06
In an earlier version of my PR to reduce allocation event size, I was passing a callback to save_context to reserve size in ring buffer. function_ref allowed to pass a capturing lambda without the extra cost associated to std::function. Since I changed my implementation, I do not need this anymore, I changed the PR status to draft.
Thanks for leaving as draft. I was actually considering std::functions recently and was not sure of the cost.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on PR #336
Add https://github.com/zhihaoy/nontype_functional as third party, this provides a function_ref implementation (non-owning cheap alternative to
std::function
).