Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some dependencies on ddprof::Parser #336

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

nsavoire
Copy link
Collaborator

@nsavoire nsavoire commented Oct 24, 2023

Split ddprof_cmdline into 2 files
This allows to removing dependency on ddprof::Parser for profiling lib and some unit tests.

@nsavoire nsavoire self-assigned this Oct 24, 2023
@nsavoire nsavoire changed the title Split ddprof_cmdline into 2 files Remove some dependencies on ddprof::Parser Oct 24, 2023
@nsavoire nsavoire force-pushed the nsavoire/remove_dependencies_on_ddprof_parser branch from 682f4ba to 000ddde Compare October 24, 2023 13:55
@nsavoire nsavoire mentioned this pull request Oct 24, 2023
This allows to removing dependency on ddprof::Parser for profiling lib
and some unit tests.
@nsavoire nsavoire force-pushed the nsavoire/remove_dependencies_on_ddprof_parser branch from 000ddde to c485204 Compare October 24, 2023 14:14
@pr-commenter
Copy link

pr-commenter bot commented Oct 24, 2023

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.15.0+99326392.22228515 ddprof 0.15.0+c485204b.22279539

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh unsure
[-40.414ms; -4.742ms] or [-1.032%; -0.121%]

@pr-commenter
Copy link

pr-commenter bot commented Oct 24, 2023

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.15.0+99326392.22228515 ddprof 0.15.0+c485204b.22279539

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Good idea.

@r1viollet r1viollet merged commit 2e35971 into main Oct 26, 2023
@r1viollet r1viollet deleted the nsavoire/remove_dependencies_on_ddprof_parser branch October 26, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants