Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lib-injection): use docker compose instead of docker-compose #8844

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Apr 3, 2024

CI: Some lib-injection tests were failing because "docker-compose" is now spelled "docker compose".

Before: https://github.com/DataDog/dd-trace-py/actions/runs/8530520596/job/23368473319
Now: https://github.com/DataDog/dd-trace-py/actions/runs/8537753296?pr=8844

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@gnufede gnufede changed the title use docker compose instead of docker-compose ci: use docker compose instead of docker-compose Apr 3, 2024
@gnufede gnufede changed the title ci: use docker compose instead of docker-compose ci(lib injection): use docker compose instead of docker-compose Apr 3, 2024
@gnufede gnufede changed the title ci(lib injection): use docker compose instead of docker-compose ci(lib-injection): use docker compose instead of docker-compose Apr 3, 2024
@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. CI labels Apr 3, 2024
@gnufede gnufede marked this pull request as ready for review April 3, 2024 11:23
@gnufede gnufede requested a review from a team as a code owner April 3, 2024 11:23
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Apr 3, 2024

Datadog Report

Branch report: gnufede/fix-libinjection-docker-compose-not-found
Commit report: 6fb931f
Test service: dd-trace-py

❌ 6 Failed (0 Known Flaky), 144567 Passed, 28389 Skipped, 9h 10m 28.98s Total duration (2h 50m 5.93s time saved)

❌ Failed Tests (6)

This report shows up to 5 failed tests.

  • test_app_started_event_configuration_override - test_writer.py - Details

    Expand for error
     assert [{'name': 'DD...': True}, ...] == [{'name': 'DD...': True}, ...]
       At index 9 diff: {'name': 'DD_PROFILING_EXPORT_LIBDD_ENABLED', 'origin': 'unknown', 'value': False} != {'name': 'DD_PROFILING_EXPORT_LIBDD_ENABLED', 'origin': 'unknown', 'value': True}
       Use -v to get more diff
    
  • test_app_started_event_configuration_override - test_writer.py - Details

    Expand for error
     assert [{'name': 'DD...': True}, ...] == [{'name': 'DD...': True}, ...]
       At index 9 diff: {'name': 'DD_PROFILING_EXPORT_LIBDD_ENABLED', 'origin': 'unknown', 'value': False} != {'name': 'DD_PROFILING_EXPORT_LIBDD_ENABLED', 'origin': 'unknown', 'value': True}
       Use -v to get more diff
    
  • test_app_started_event_configuration_override - test_writer.py - Details

    Expand for error
     assert [{'name': 'DD...': True}, ...] == [{'name': 'DD...': True}, ...]
       At index 9 diff: {'name': 'DD_PROFILING_EXPORT_LIBDD_ENABLED', 'origin': 'unknown', 'value': False} != {'name': 'DD_PROFILING_EXPORT_LIBDD_ENABLED', 'origin': 'unknown', 'value': True}
       Use -v to get more diff
    
  • test_app_started_event_configuration_override - test_writer.py - Details

    Expand for error
     assert [{'name': 'DD...': True}, ...] == [{'name': 'DD...': True}, ...]
       At index 9 diff: {'name': 'DD_PROFILING_EXPORT_LIBDD_ENABLED', 'origin': 'unknown', 'value': False} != {'name': 'DD_PROFILING_EXPORT_LIBDD_ENABLED', 'origin': 'unknown', 'value': True}
       Use -v to get more diff
    
  • test_app_started_event_configuration_override - test_writer.py - Details

    Expand for error
     assert [{'name': 'DD...': True}, ...] == [{'name': 'DD...': True}, ...]
       At index 9 diff: {'name': 'DD_PROFILING_EXPORT_LIBDD_ENABLED', 'origin': 'unknown', 'value': False} != {'name': 'DD_PROFILING_EXPORT_LIBDD_ENABLED', 'origin': 'unknown', 'value': True}
       Use -v to get more diff
    

@gnufede gnufede enabled auto-merge (squash) April 3, 2024 13:16
@emmettbutler
Copy link
Collaborator

@gnufede jinx! #8833

@pr-commenter
Copy link

pr-commenter bot commented Apr 3, 2024

Benchmarks

Benchmark execution time: 2024-04-03 13:34:39

Comparing candidate commit 8763538 in PR branch gnufede/fix-libinjection-docker-compose-not-found with baseline commit b085205 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 179 metrics, 9 unstable metrics.

@gnufede gnufede merged commit 7c011b9 into main Apr 3, 2024
53 of 57 checks passed
@gnufede gnufede deleted the gnufede/fix-libinjection-docker-compose-not-found branch April 3, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants