Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use v2 command for docker-compose #8833

Closed
wants to merge 2 commits into from

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Apr 2, 2024

This change updates the Github Action that uses docker-compose to call the appropriate command given the recent upgrade of that software on the ubuntu Action image described in actions/runner-images#9557. This had been leading to CI failures like this.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested a review from a team as a code owner April 2, 2024 19:05
@emmettbutler emmettbutler marked this pull request as draft April 2, 2024 19:05
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 2, 2024
@emmettbutler emmettbutler marked this pull request as ready for review April 2, 2024 19:14
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: emmett.butler/docker-compose-v2
Commit report: f4fbdf0
Test service: dd-trace-py

✅ 0 Failed, 82471 Passed, 90399 Skipped, 8h 44m 55.67s Total duration (3h 16m 1.37s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Apr 2, 2024

Benchmarks

Benchmark execution time: 2024-04-02 21:03:02

Comparing candidate commit f9f3e8c in PR branch emmett.butler/docker-compose-v2 with baseline commit 1c1f54a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 201 metrics, 9 unstable metrics.

@emmettbutler
Copy link
Collaborator Author

#8844

auto-merge was automatically disabled April 3, 2024 13:26

Pull request was closed

@emmettbutler emmettbutler deleted the emmett.butler/docker-compose-v2 branch April 3, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant