-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mypy): avoid parsing redis asyncio files with Python 2 #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
previously approved these changes
Jun 27, 2022
Kyle-Verhoog
previously approved these changes
Jun 27, 2022
mabdinur
force-pushed
the
majorgreys/fix-mypy-py2-redis
branch
2 times, most recently
from
June 30, 2022 18:38
5bb42d4
to
30361e7
Compare
mabdinur
force-pushed
the
majorgreys/fix-mypy-py2-redis
branch
from
June 30, 2022 18:39
30361e7
to
7eb736d
Compare
mabdinur
previously approved these changes
Jun 30, 2022
14 tasks
mabdinur
force-pushed
the
majorgreys/fix-mypy-py2-redis
branch
from
July 1, 2022 14:37
7eb736d
to
408e8f2
Compare
brettlangdon
previously approved these changes
Jul 1, 2022
jd
previously approved these changes
Jul 4, 2022
mabdinur
force-pushed
the
majorgreys/fix-mypy-py2-redis
branch
from
July 5, 2022 13:35
408e8f2
to
cc80ca8
Compare
majorgreys
force-pushed
the
majorgreys/fix-mypy-py2-redis
branch
from
July 5, 2022 14:43
38a6bde
to
6191a6a
Compare
Codecov Report
@@ Coverage Diff @@
## 1.x #3868 +/- ##
==========================================
- Coverage 78.78% 78.70% -0.08%
==========================================
Files 685 687 +2
Lines 53121 53356 +235
==========================================
+ Hits 41850 41996 +146
- Misses 11271 11360 +89
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
mabdinur
approved these changes
Jul 5, 2022
Kyle-Verhoog
approved these changes
Jul 5, 2022
@Mergifyio backport 1.2 |
🟠 Waiting for conditions to match
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 5, 2022
## Description Fixes #3845 ## Checklist - [ ] Title must conform to [conventional commit](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional). - [ ] Add additional sections for `feat` and `fix` pull requests. - [ ] Ensure tests are passing for affected code. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. ## Testing strategy We do not as yet run Python 2 type checking so this will have to be tested manually. ## Reviewer Checklist - [x] Title is accurate. - [x] Description motivates each change. - [x] No unnecessary changes were introduced in this PR. - [x] PR cannot be broken up into smaller PRs. - [x] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Tests provided or description of manual testing performed is included in the code or PR. - [x] Release note has been added for fixes and features, or else `changelog/no-changelog` label added. - [x] All relevant GitHub issues are correctly linked. - [x] Backports are identified and tagged with Mergifyio. - [ ] Add to milestone. (cherry picked from commit d2ed33a)
✅ Backports have been created
|
Kyle-Verhoog
pushed a commit
that referenced
this pull request
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3845
Checklist
feat
andfix
pull requests.Testing strategy
We do not as yet run Python 2 type checking so this will have to be tested manually.
Reviewer Checklist
changelog/no-changelog
label added.