Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy invalid syntax error with python 2 #3845

Closed
majorgreys opened this issue Jun 22, 2022 · 0 comments · Fixed by #3868
Closed

mypy invalid syntax error with python 2 #3845

majorgreys opened this issue Jun 22, 2022 · 0 comments · Fixed by #3868

Comments

@majorgreys
Copy link
Contributor

Which version of dd-trace-py are you using?

v1.2.0

Which version of pip are you using?

22.1.2

Which version of the libraries are you using?

ddtrace==1.2.0
mypy[python2]==0.961

How can we reproduce your problem?

  1. Clone https://gist.github.com/majorgreys/720201c4bdd33131e4c231207ef716ce
  2. Run docker run --rm -it (docker build .)

What is the result that you get?

usr/local/lib/python3.9/site-packages/ddtrace/contrib/redis/asyncio_patch.py:12: error: invalid syntax
Found 1 error in 1 file (errors prevented further checking)

What is the result that you expected?

Success: no issues found in 1 source file
@majorgreys majorgreys mentioned this issue Jun 22, 2022
Closed
14 tasks
@majorgreys majorgreys changed the title mypy invalid syntax error with py2 mypy invalid syntax error with python 2 Jun 22, 2022
@majorgreys majorgreys mentioned this issue Jun 27, 2022
Merged
14 tasks
@mergify mergify bot closed this as completed in #3868 Jul 5, 2022
mergify bot pushed a commit that referenced this issue Jul 5, 2022
@majorgreys
fix(mypy): avoid parsing redis asyncio files with Python 2 (#3868)
d2ed33a 
## Description

Fixes #3845  



## Checklist
- [ ] Title must conform to [conventional commit](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional).
- [ ] Add additional sections for `feat` and `fix` pull requests.
- [ ] Ensure tests are passing for affected code.
- [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description.




## Testing strategy

We do not as yet run Python 2 type checking so this will have to be tested manually.

## Reviewer Checklist
- [x] Title is accurate.
- [x] Description motivates each change.
- [x] No unnecessary changes were introduced in this PR.
- [x] PR cannot be broken up into smaller PRs.
- [x] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary.
- [x] Tests provided or description of manual testing performed is included in the code or PR.
- [x] Release note has been added for fixes and features, or else `changelog/no-changelog` label added.
- [x] All relevant GitHub issues are correctly linked.
- [x] Backports are identified and tagged with Mergifyio.
- [ ] Add to milestone.
mergify bot pushed a commit that referenced this issue Jul 5, 2022
@majorgreys @mergify
fix(mypy): avoid parsing redis asyncio files with Python 2 (#3868)
9b03391 
## Description

Fixes #3845

## Checklist
- [ ] Title must conform to [conventional commit](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional).
- [ ] Add additional sections for `feat` and `fix` pull requests.
- [ ] Ensure tests are passing for affected code.
- [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description.

## Testing strategy

We do not as yet run Python 2 type checking so this will have to be tested manually.

## Reviewer Checklist
- [x] Title is accurate.
- [x] Description motivates each change.
- [x] No unnecessary changes were introduced in this PR.
- [x] PR cannot be broken up into smaller PRs.
- [x] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary.
- [x] Tests provided or description of manual testing performed is included in the code or PR.
- [x] Release note has been added for fixes and features, or else `changelog/no-changelog` label added.
- [x] All relevant GitHub issues are correctly linked.
- [x] Backports are identified and tagged with Mergifyio.
- [ ] Add to milestone.

(cherry picked from commit d2ed33a)
Kyle-Verhoog pushed a commit that referenced this issue Jul 5, 2022
@mergify @majorgreys
fix(mypy): avoid parsing redis asyncio files with Python 2 (#3868) (#…
d370b73 
…3906)

## Description

Fixes #3845

Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mypy): avoid parsing redis asyncio files with Python 2 DataDog/dd-trace-py
1 participant
@majorgreys