Fix backtraces 8.4 #2812
Merged
Fix backtraces 8.4 #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## florian/php-8.4 #2812 +/- ##
=====================================================
- Coverage 78.49% 78.49% -0.01%
Complexity 2516 2516
=====================================================
Files 173 173
Lines 18677 18679 +2
Branches 975 976 +1
=====================================================
+ Hits 14661 14662 +1
Misses 3479 3479
- Partials 537 538 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
BenchmarksBenchmark execution time: 2024-08-26 09:10:11 Comparing candidate commit 79397be in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics. |
realFlowControl
approved these changes
Aug 26, 2024
bwoebi
added a commit
that referenced
this pull request
Oct 30, 2024
* add PHP 8.4 * PHP 8.4 interceptor compatibility Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Add missing dependencies in CircleCI jobs * pecl php 8.4 * make appsec compile with PHP 8.4 * Add PHP 8.4 windows support * run verify php 8.4 only on alpine * update prof correctness to new closure frames * Reduce visual studio parts needing to be installed * fix prof correctness * fix PHP 8.4 closure tests * update PHP 8.4 to beta3 * fix xdebug * fix circleci * fix appsec * Fix warning: Warning: JIT on AArch64 doesn't support opcache.jit_buffer_size above 128M. in Unknown on line 0 Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Fix closures on PHP 8.4 (#2812) * update to RC1 * Fix cross-compile Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * update to RC1 * fix tests * fix xdebug * fix comment * set xdebug for loader test * Adapt to PHP 8.4 stuff Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * fix build extension * update to llvm 17 * cmake * add libltdl-dev for php 7 * add libltdl-dev for php 7 * asdf * fix warning `as` vs `AS` * use new asan * bump llvm to 17 * fix xdebug php 8.3Ä * Add missing libclang-rt-17-dev * Include frameless functions in stack walk Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * fix php < 8.4 compile * fix: warning about unused variable * perf: PHP 8.4+ doesn't need zend_execute_internal * add zts to buster php 7 * add tar * Add clang ASAN handling Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * stuff * Fix asan stuff Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * updates * Use cc instead of gcc in CI Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * fix 8.1 * fix * upadte 8.3 in other OS as well * Fix compile issues Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * update 8.4 to rc3 * Try fix more compile issues Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * fix llvm vs gcc flags * fix dns_check_record() * Fix sidecar asan Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Update php 8.4 windows version * Fix everything Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Make coverage jobs independent Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Skip ubsan tea tests for PHP 7.0-7.3 Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Exclude some tests from running Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * fix cmake asan * disable code coverage * Fix tea tests Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * It's forbidden to use EG(uninitialized_zval) in ZTS in startup Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Fix stacktarget handling in zai_hook_safe_finish Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> --------- Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com> Co-authored-by: Alejandro Estringana Ruiz <alejandro.estringanaruiz@datadoghq.com> Co-authored-by: Levi Morrison <levi.morrison@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PHP 8.4 changed the string version of a closure. This PR filters out ddtrace closures on 8.4.
Reviewer checklist