Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 support #2758

Merged
merged 104 commits into from
Oct 30, 2024
Merged

PHP 8.4 support #2758

merged 104 commits into from
Oct 30, 2024

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Jul 12, 2024

Description

This PR will bring support for PHP 8.4 🎉

PROF-10137

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.24%. Comparing base (093ef34) to head (2c614f2).

Files with missing lines Patch % Lines
appsec/src/extension/backtrace.c 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2758      +/-   ##
============================================
+ Coverage     78.21%   78.24%   +0.02%     
  Complexity     2526     2526              
============================================
  Files           173      135      -38     
  Lines         18752    14400    -4352     
  Branches        988      989       +1     
============================================
- Hits          14667    11267    -3400     
+ Misses         3544     2591     -953     
- Partials        541      542       +1     
Flag Coverage Δ
appsec-extension 68.36% <66.66%> (-0.01%) ⬇️
tracer-extension ?
tracer-php 82.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appsec/src/extension/configuration.c 62.62% <ø> (ø)
appsec/src/extension/ddappsec.c 70.56% <ø> (ø)
appsec/src/extension/ddtrace.c 60.00% <ø> (ø)
appsec/src/extension/helper_process.c 62.23% <ø> (ø)
appsec/src/extension/ip_extraction.c 75.00% <ø> (ø)
appsec/src/extension/logging.c 71.11% <ø> (ø)
appsec/src/extension/logging.h 100.00% <ø> (ø)
appsec/src/extension/msgpack_helpers.c 55.05% <ø> (ø)
appsec/src/extension/php_objects.c 85.71% <ø> (ø)
appsec/src/extension/request_abort.c 72.28% <ø> (ø)
... and 3 more

... and 38 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 093ef34...2c614f2. Read the comment docs.

@realFlowControl realFlowControl force-pushed the florian/php-8.4 branch 18 times, most recently from 37285f3 to ea272a5 Compare July 16, 2024 10:59
@pr-commenter
Copy link

pr-commenter bot commented Jul 16, 2024

Benchmarks

Benchmark execution time: 2024-09-12 13:37:00

Comparing candidate commit 29864d4 in PR branch florian/php-8.4 with baseline commit ddf15fe in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟥 execution_time [+12.483µs; +14.526µs] or [+6.994%; +8.139%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟥 execution_time [+13.733µs; +16.923µs] or [+4.781%; +5.892%]

scenario:WordPressBench/benchWordPressOverhead

  • 🟩 execution_time [-21.857ms; -21.671ms] or [-82.926%; -82.218%]

@realFlowControl realFlowControl force-pushed the florian/php-8.4 branch 9 times, most recently from 47dcd62 to db80fe9 Compare July 17, 2024 05:36
bwoebi and others added 18 commits October 24, 2024 21:33
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
realFlowControl and others added 2 commits October 28, 2024 12:13
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 14 CI failures left. Nothing critical, something we theoretically might release with.
Let's merge it and improve upon it later.

@bwoebi bwoebi merged commit 73e9db0 into master Oct 30, 2024
777 of 793 checks passed
@bwoebi bwoebi deleted the florian/php-8.4 branch October 30, 2024 10:06
@github-actions github-actions bot added this to the 1.5.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants