-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.4 support #2758
PHP 8.4 support #2758
Conversation
5a2777c
to
4d9610e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2758 +/- ##
============================================
+ Coverage 78.21% 78.24% +0.02%
Complexity 2526 2526
============================================
Files 173 135 -38
Lines 18752 14400 -4352
Branches 988 989 +1
============================================
- Hits 14667 11267 -3400
+ Misses 3544 2591 -953
- Partials 541 542 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 38 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
37285f3
to
ea272a5
Compare
BenchmarksBenchmark execution time: 2024-09-12 13:37:00 Comparing candidate commit 29864d4 in PR branch Found 1 performance improvements and 2 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics. scenario:PDOBench/benchPDOBaseline-opcache
scenario:PDOBench/benchPDOOverhead-opcache
scenario:WordPressBench/benchWordPressOverhead
|
47dcd62
to
db80fe9
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
…o florian/php-8.4
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
…o florian/php-8.4
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
23de8c2
to
c99434b
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
5af265d
to
006d76b
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
db5ef76
to
2c614f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have 14 CI failures left. Nothing critical, something we theoretically might release with.
Let's merge it and improve upon it later.
Description
This PR will bring support for PHP 8.4 🎉
PROF-10137
Reviewer checklist