Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hunt memory leak #2619

Closed
wants to merge 7 commits into from
Closed

Hunt memory leak #2619

wants to merge 7 commits into from

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Apr 9, 2024

Description

Based on branch ddtrace-0.99.1

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@pr-commenter
Copy link

pr-commenter bot commented Apr 9, 2024

Benchmarks

Benchmark execution time: 2024-04-10 09:57:17

Comparing candidate commit e2db360 in PR branch lv/hunt-mem-leak with baseline commit 8de3b1f in branch ddtrace-0.99.1.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 3 unstable metrics.

@iamluc iamluc force-pushed the lv/hunt-mem-leak branch from 4a1f6f9 to 3ea2364 Compare April 9, 2024 12:59
@iamluc iamluc force-pushed the lv/hunt-mem-leak branch from 3ea2364 to f36beac Compare April 9, 2024 14:08
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

Merging #2619 (e2db360) into ddtrace-0.99.1 (8de3b1f) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             ddtrace-0.99.1    #2619   +/-   ##
=================================================
  Coverage             75.39%   75.39%           
  Complexity             2607     2607           
=================================================
  Files                   243      243           
  Lines                 27266    27316   +50     
  Branches                985      985           
=================================================
+ Hits                  20556    20595   +39     
- Misses                 6185     6196   +11     
  Partials                525      525           
Flag Coverage Δ
appsec-extension 69.01% <ø> (ø)
tracer-extension 78.62% <73.80%> (-0.02%) ⬇️
tracer-php 73.86% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ext/ddtrace.h 62.50% <ø> (ø)
ext/ddtrace_arginfo.h 100.00% <100.00%> (ø)
ext/span.c 93.01% <100.00%> (+0.01%) ⬆️
ext/span.h 100.00% <ø> (ø)
src/DDTrace/OpenTelemetry/Span.php 86.11% <100.00%> (+0.07%) ⬆️
src/DDTrace/OpenTracer/Tracer.php 86.88% <100.00%> (+0.92%) ⬆️
src/DDTrace/OpenTracer1/Tracer.php 86.66% <100.00%> (+0.95%) ⬆️
ext/telemetry.c 96.42% <89.65%> (-3.58%) ⬇️
ext/ddtrace.c 72.72% <20.00%> (-0.37%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de3b1f...e2db360. Read the comment docs.

@iamluc iamluc force-pushed the lv/hunt-mem-leak branch from a356ac2 to 2c22f02 Compare April 10, 2024 07:27
@iamluc iamluc force-pushed the lv/hunt-mem-leak branch from 2c22f02 to c67d918 Compare April 10, 2024 07:48
@bwoebi
Copy link
Collaborator

bwoebi commented Apr 12, 2024

Memory leak found, closing :-)

@bwoebi bwoebi closed this Apr 12, 2024
@iamluc iamluc deleted the lv/hunt-mem-leak branch April 12, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants