Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-visibility] Use system's node instead of the bundled one in cypress tests #4011

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

juan-fernandez
Copy link
Collaborator

What does this PR do?

The nodeVersion old configuration parameter (https://docs.cypress.io/guides/references/legacy-configuration#Node-version) allows you to specify the version of node you use for your plugins. By default it's the bundled in cypress, but you can change it to system.

Motivation

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@juan-fernandez juan-fernandez marked this pull request as ready for review January 30, 2024 13:43
@juan-fernandez juan-fernandez requested a review from a team as a code owner January 30, 2024 13:43
Copy link

github-actions bot commented Jan 30, 2024

Overall package size

Self size: 5.96 MB
Deduped: 61.65 MB
No deduping: 62.41 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 7.0.0 14.51 MB 14.52 MB
@datadog/pprof 5.0.0 9.59 MB 10.44 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.2 2.29 MB 2.37 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c3157e) 66.38% compared to head (d60b490) 85.12%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4011       +/-   ##
===========================================
+ Coverage   66.38%   85.12%   +18.73%     
===========================================
  Files         233      242        +9     
  Lines        9738    10441      +703     
  Branches       33       33               
===========================================
+ Hits         6465     8888     +2423     
+ Misses       3273     1553     -1720     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2024

Benchmarks

Benchmark execution time: 2024-01-30 16:19:07

Comparing candidate commit d60b490 in PR branch juan-fernandez/use-node-version-cypress with baseline commit 7c3157e in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics.

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-95.603MB; -61.309MB] or [-10.429%; -6.688%]

simon-id
simon-id previously approved these changes Jan 30, 2024
@juan-fernandez juan-fernandez merged commit d904510 into master Jan 30, 2024
111 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/use-node-version-cypress branch January 30, 2024 17:44
@tlhunter tlhunter mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants