Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated polyfills #4009

Merged
merged 14 commits into from
May 24, 2024
Merged

Remove outdated polyfills #4009

merged 14 commits into from
May 24, 2024

Conversation

simon-id
Copy link
Member

@simon-id simon-id commented Jan 30, 2024

What does this PR do?

Removes a number of polyfill dependencies that are not needed anymore due to the feature being included natively in Node.

  • crypto-randomuuid Added in: v15.6.0, v14.17.0 required by old Cypress version
  • ipaddr.js Added in: v15.0.0, v14.18.0
  • node-abort-controller Added in: v15.0.0, v14.17.0
  • methods Added in: v0.11.8 (lol)

Apparently saving 100kB in overall package size.

As these native features have been mostly added after node 15, this PR should only be landed after v3 has been dropped.

@simon-id simon-id self-assigned this Jan 30, 2024
@simon-id simon-id added semver-patch dont-land-on-v3.x If a commit depends on a major change not included in v3.x labels Jan 30, 2024
Copy link

github-actions bot commented Jan 30, 2024

Overall package size

Self size: 6.5 MB
Deduped: 60.56 MB
No deduping: 60.84 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.19%. Comparing base (8f9e558) to head (0ffa269).
Report is 14 commits behind head on master.

Current head 0ffa269 differs from pull request most recent head ec32eae

Please upload reports for the commit ec32eae to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4009       +/-   ##
===========================================
- Coverage   85.23%   69.19%   -16.05%     
===========================================
  Files         252        1      -251     
  Lines       11042      198    -10844     
  Branches       33       33               
===========================================
- Hits         9412      137     -9275     
+ Misses       1630       61     -1569     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2024

Benchmarks

Benchmark execution time: 2024-01-31 16:45:04

Comparing candidate commit dd46995 in PR branch remove_outdated_polyfills with baseline commit 0e9fc0a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics.

@simon-id simon-id marked this pull request as ready for review May 23, 2024 15:18
@simon-id simon-id requested review from a team as code owners May 23, 2024 15:18
@simon-id simon-id merged commit 95b5a41 into master May 24, 2024
108 checks passed
@simon-id simon-id deleted the remove_outdated_polyfills branch May 24, 2024 07:36
juan-fernandez pushed a commit that referenced this pull request Jun 4, 2024
* remove ipaddr.js

* remove node-abort-controller

* remove methods
juan-fernandez pushed a commit that referenced this pull request Jun 4, 2024
* remove ipaddr.js

* remove node-abort-controller

* remove methods
This was referenced Jun 5, 2024
juan-fernandez pushed a commit that referenced this pull request Jun 5, 2024
* remove ipaddr.js

* remove node-abort-controller

* remove methods
juan-fernandez pushed a commit that referenced this pull request Jun 5, 2024
* remove ipaddr.js

* remove node-abort-controller

* remove methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-land-on-v3.x If a commit depends on a major change not included in v3.x semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants