-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated polyfills #4009
Conversation
Overall package sizeSelf size: 6.5 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4009 +/- ##
===========================================
- Coverage 85.23% 69.19% -16.05%
===========================================
Files 252 1 -251
Lines 11042 198 -10844
Branches 33 33
===========================================
- Hits 9412 137 -9275
+ Misses 1630 61 -1569 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-01-31 16:45:04 Comparing candidate commit dd46995 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics. |
* remove ipaddr.js * remove node-abort-controller * remove methods
* remove ipaddr.js * remove node-abort-controller * remove methods
* remove ipaddr.js * remove node-abort-controller * remove methods
* remove ipaddr.js * remove node-abort-controller * remove methods
What does this PR do?
Removes a number of polyfill dependencies that are not needed anymore due to the feature being included natively in Node.
required by old Cypress versioncrypto-randomuuid
Added in: v15.6.0, v14.17.0ipaddr.js
Added in: v15.0.0, v14.18.0node-abort-controller
Added in: v15.0.0, v14.17.0methods
Added in: v0.11.8 (lol)Apparently saving 100kB in overall package size.
As these native features have been mostly added after node 15, this PR should only be landed after v3 has been dropped.