Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move HttpServer, Http2Server plugins to ServerPlugins #3261

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

jbertran
Copy link
Contributor

What does this PR do?

Make HttpServer and Http2Server plugins to ServerPlugin. This moves them to the (semantically) right place in the plugin hierarchy, and gives us access to TracingPlugin behaviour, which allows us to use the service naming API with these plugins.

Additional Notes

With the current state of both plugins, we could make HttpServerPlugin a child of Http2ServerPlugin to minimize code in the former. However, from #312 and #2415 this similarity is only due to the fact that we currently support Http2 in best-effort compatibility mode, so I don't want to couple the 2 implementations together and make it harder to correctly support it down the road.

@jbertran jbertran requested a review from a team as a code owner June 20, 2023 09:37
@github-actions
Copy link

github-actions bot commented Jun 20, 2023

Overall package size

Self size: 4.36 MB
Deduped: 60.82 MB
No deduping: 60.86 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #3261 (3b53426) into master (89da666) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3261   +/-   ##
=======================================
  Coverage   86.04%   86.05%           
=======================================
  Files         194      196    +2     
  Lines        7518     7523    +5     
  Branches       33       33           
=======================================
+ Hits         6469     6474    +5     
  Misses       1049     1049           

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Jun 20, 2023

Benchmarks

Comparing candidate commit 3b53426 in PR branch jbertran/http-servers with baseline commit 89da666 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 462 metrics, 30 unstable metrics.

@jbertran jbertran merged commit 6770761 into master Jun 23, 2023
tlhunter added a commit that referenced this pull request Jun 29, 2023
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
tlhunter added a commit that referenced this pull request Jun 29, 2023
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
tlhunter added a commit that referenced this pull request Jun 29, 2023
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
tlhunter added a commit that referenced this pull request Jun 29, 2023
This was referenced Jun 29, 2023
tlhunter added a commit that referenced this pull request Jun 30, 2023
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
tlhunter added a commit that referenced this pull request Jun 30, 2023
tlhunter added a commit that referenced this pull request Jun 30, 2023
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
tlhunter added a commit that referenced this pull request Jun 30, 2023
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
@tlhunter tlhunter deleted the jbertran/http-servers branch December 18, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants