-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move HttpServer
, Http2Server
plugins to ServerPlugin
s
#3261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 4.36 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3261 +/- ##
=======================================
Coverage 86.04% 86.05%
=======================================
Files 194 196 +2
Lines 7518 7523 +5
Branches 33 33
=======================================
+ Hits 6469 6474 +5
Misses 1049 1049 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tlhunter
approved these changes
Jun 22, 2023
tlhunter
added a commit
that referenced
this pull request
Jun 29, 2023
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
tlhunter
added a commit
that referenced
this pull request
Jun 29, 2023
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
tlhunter
added a commit
that referenced
this pull request
Jun 29, 2023
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
tlhunter
added a commit
that referenced
this pull request
Jun 29, 2023
tlhunter
added a commit
that referenced
this pull request
Jun 30, 2023
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
tlhunter
added a commit
that referenced
this pull request
Jun 30, 2023
tlhunter
added a commit
that referenced
this pull request
Jun 30, 2023
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
tlhunter
added a commit
that referenced
this pull request
Jun 30, 2023
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make
HttpServer
andHttp2Server
plugins toServerPlugin
. This moves them to the (semantically) right place in the plugin hierarchy, and gives us access toTracingPlugin
behaviour, which allows us to use the service naming API with these plugins.Additional Notes
With the current state of both plugins, we could make
HttpServerPlugin
a child ofHttp2ServerPlugin
to minimize code in the former. However, from #312 and #2415 this similarity is only due to the fact that we currently supportHttp2
in best-effort compatibility mode, so I don't want to couple the 2 implementations together and make it harder to correctly support it down the road.