Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for http2 servers in compatibility mode #2415

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

Qard
Copy link
Contributor

@Qard Qard commented Sep 29, 2022

This is an experiment to see if we can easily support http2 server instrumentation for the compatibility-mode interface.

@github-actions
Copy link

github-actions bot commented Sep 29, 2022

Overall package size

Self size: 2.81 MB
Deduped: 31.88 MB
No deduping: 32.09 MB

Dependency sizes

name version self size total size
@datadog/pprof 1.0.2 8.74 MB 16.25 MB
@datadog/native-metrics 1.4.3 6.57 MB 6.58 MB
@datadog/native-appsec 1.2.1 5.1 MB 5.43 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
semver 5.7.1 61.58 kB 61.58 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.4 32.7 kB 37.17 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@Qard Qard force-pushed the http2-server-instrumentation branch from fbe7697 to f82ad3c Compare September 29, 2022 18:50
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #2415 (01435ed) into master (f767046) will decrease coverage by 0.06%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master    #2415      +/-   ##
==========================================
- Coverage   92.65%   92.58%   -0.07%     
==========================================
  Files         246      248       +2     
  Lines        9351     9467     +116     
==========================================
+ Hits         8664     8765     +101     
- Misses        687      702      +15     
Impacted Files Coverage Δ
...kages/datadog-instrumentations/src/http2/server.js 93.93% <93.93%> (ø)
packages/datadog-plugin-http2/src/server.js 91.66% <95.23%> (+25.00%) ⬆️
packages/datadog-plugin-jest/src/index.js 95.38% <0.00%> (-1.17%) ⬇️
...y/intelligent-test-runner/get-itr-configuration.js 16.66% <0.00%> (ø)
...ce/src/ci-visibility/exporters/git/git_metadata.js 97.50% <0.00%> (+0.03%) ⬆️
packages/datadog-instrumentations/src/jest.js 98.44% <0.00%> (+0.15%) ⬆️
packages/dd-trace/src/plugins/util/git.js 73.52% <0.00%> (+37.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Qard Qard force-pushed the http2-server-instrumentation branch 3 times, most recently from a72803f to 24f1148 Compare October 1, 2022 05:19
@Qard Qard force-pushed the http2-server-instrumentation branch from 24f1148 to 004fb11 Compare October 1, 2022 05:24
@Qard Qard marked this pull request as ready for review October 1, 2022 05:30
@Qard Qard requested a review from a team as a code owner October 1, 2022 05:30
@rochdev rochdev merged commit 8c14bb3 into master Oct 5, 2022
tlhunter pushed a commit that referenced this pull request Oct 6, 2022
* Add support for http2 servers in compatibility mode

* fix typo

Co-authored-by: Roch Devost <roch.devost@datadoghq.com>
tlhunter pushed a commit that referenced this pull request Oct 6, 2022
* Add support for http2 servers in compatibility mode

* fix typo

Co-authored-by: Roch Devost <roch.devost@datadoghq.com>
tlhunter pushed a commit that referenced this pull request Oct 6, 2022
* Add support for http2 servers in compatibility mode

* fix typo

Co-authored-by: Roch Devost <roch.devost@datadoghq.com>
tlhunter pushed a commit that referenced this pull request Oct 6, 2022
* Add support for http2 servers in compatibility mode

* fix typo

Co-authored-by: Roch Devost <roch.devost@datadoghq.com>
@Qard Qard deleted the http2-server-instrumentation branch December 19, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants