Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate certain instrumentations to use closeActive() to close outstanding spans #8503

Merged
merged 6 commits into from
Mar 5, 2025
Merged

Migrate certain instrumentations to use closeActive() to close outstanding spans #8503

merged 6 commits into from
Mar 5, 2025

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Mar 4, 2025 •
edited by jira bot
Loading

Motivation

These instrumentations just want to close the active span when it matches certain criteria.

Since #8478 they can now use activeSpan() to check the active span and closeActive() to close it

Contributor Checklist

Jira ticket: APMAPI-956

@mcculls mcculls added inst: others All other instrumentations tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 4, 2025
@pr-commenter
Copy link

pr-commenter bot commented Mar 4, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/prefer-closeActive-to-activeScope.close
git_commit_date 1741201628 1741202768
git_commit_sha 039404d 6bf7101
release_version 1.48.0-SNAPSHOT~039404dfa5 1.48.0-SNAPSHOT~6bf71015f7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741205103 1741205103
ci_job_id 834479539 834479539
ci_pipeline_id 57840964 57840964
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-snmtyxn8-project-304-concurrent-4-39hebd99 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-snmtyxn8-project-304-concurrent-4-39hebd99 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~6bf71015f7, baseline=1.48.0-SNAPSHOT~039404dfa5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.036 s) : 0, 1036323
Total [baseline] (8.629 s) : 0, 8629083
Agent [candidate] (1.043 s) : 0, 1042746
Total [candidate] (8.687 s) : 0, 8686846
section iast
Agent [baseline] (1.174 s) : 0, 1174048
Total [baseline] (9.234 s) : 0, 9233971
Agent [candidate] (1.169 s) : 0, 1169294
Total [candidate] (9.232 s) : 0, 9231745
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1170614
Total [baseline] (9.209 s) : 0, 9209324
Agent [candidate] (1.169 s) : 0, 1169304
Total [candidate] (9.176 s) : 0, 9176472
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1172959
Total [baseline] (9.23 s) : 0, 9229676
Agent [candidate] (1.168 s) : 0, 1168268
Total [candidate] (9.2 s) : 0, 9199614
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.036 s -
Agent iast 1.174 s 137.725 ms (13.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 134.291 ms (13.0%)
Agent iast_TELEMETRY_OFF 1.173 s 136.636 ms (13.2%)
Total tracing 8.629 s -
Total iast 9.234 s 604.888 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.209 s 580.241 ms (6.7%)
Total iast_TELEMETRY_OFF 9.23 s 600.593 ms (7.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent iast 1.169 s 126.548 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 126.557 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.168 s 125.522 ms (12.0%)
Total tracing 8.687 s -
Total iast 9.232 s 544.898 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.176 s 489.625 ms (5.6%)
Total iast_TELEMETRY_OFF 9.2 s 512.768 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~6bf71015f7, baseline=1.48.0-SNAPSHOT~039404dfa5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.484 ms) : 0, 715484
BytebuddyAgent [candidate] (718.387 ms) : 0, 718387
GlobalTracer [baseline] (239.018 ms) : 0, 239018
GlobalTracer [candidate] (238.803 ms) : 0, 238803
AppSec [baseline] (54.798 ms) : 0, 54798
AppSec [candidate] (55.014 ms) : 0, 55014
Remote Config [baseline] (680.006 µs) : 0, 680
Remote Config [candidate] (684.684 µs) : 0, 685
Telemetry [baseline] (11.337 ms) : 0, 11337
Telemetry [candidate] (14.905 ms) : 0, 14905
section iast
BytebuddyAgent [baseline] (839.944 ms) : 0, 839944
BytebuddyAgent [candidate] (835.545 ms) : 0, 835545
GlobalTracer [baseline] (230.509 ms) : 0, 230509
GlobalTracer [candidate] (230.002 ms) : 0, 230002
AppSec [baseline] (56.459 ms) : 0, 56459
AppSec [candidate] (56.723 ms) : 0, 56723
Remote Config [baseline] (615.81 µs) : 0, 616
Remote Config [candidate] (624.788 µs) : 0, 625
Telemetry [baseline] (8.725 ms) : 0, 8725
Telemetry [candidate] (8.732 ms) : 0, 8732
IAST [baseline] (22.796 ms) : 0, 22796
IAST [candidate] (22.771 ms) : 0, 22771
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.919 ms) : 0, 835919
BytebuddyAgent [candidate] (835.521 ms) : 0, 835521
GlobalTracer [baseline] (230.477 ms) : 0, 230477
GlobalTracer [candidate] (230.011 ms) : 0, 230011
AppSec [baseline] (56.955 ms) : 0, 56955
AppSec [candidate] (56.819 ms) : 0, 56819
Remote Config [baseline] (609.253 µs) : 0, 609
Remote Config [candidate] (620.197 µs) : 0, 620
Telemetry [baseline] (8.664 ms) : 0, 8664
Telemetry [candidate] (8.701 ms) : 0, 8701
IAST [baseline] (22.988 ms) : 0, 22988
IAST [candidate] (22.691 ms) : 0, 22691
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.813 ms) : 0, 835813
BytebuddyAgent [candidate] (834.853 ms) : 0, 834853
GlobalTracer [baseline] (232.583 ms) : 0, 232583
GlobalTracer [candidate] (230.583 ms) : 0, 230583
AppSec [baseline] (56.4 ms) : 0, 56400
AppSec [candidate] (55.645 ms) : 0, 55645
Remote Config [baseline] (629.029 µs) : 0, 629
Remote Config [candidate] (608.171 µs) : 0, 608
Telemetry [baseline] (8.834 ms) : 0, 8834
Telemetry [candidate] (8.559 ms) : 0, 8559
IAST [baseline] (23.663 ms) : 0, 23663
IAST [candidate] (23.069 ms) : 0, 23069
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~6bf71015f7, baseline=1.48.0-SNAPSHOT~039404dfa5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041441
Total [baseline] (10.436 s) : 0, 10436302
Agent [candidate] (1.04 s) : 0, 1040101
Total [candidate] (10.433 s) : 0, 10433120
section appsec
Agent [baseline] (1.182 s) : 0, 1181827
Total [baseline] (10.764 s) : 0, 10764140
Agent [candidate] (1.182 s) : 0, 1181956
Total [candidate] (10.723 s) : 0, 10723152
section iast
Agent [baseline] (1.175 s) : 0, 1175437
Total [baseline] (10.994 s) : 0, 10994148
Agent [candidate] (1.187 s) : 0, 1187138
Total [candidate] (11.092 s) : 0, 11091717
section profiling
Agent [baseline] (1.256 s) : 0, 1255654
Total [baseline] (10.775 s) : 0, 10774544
Agent [candidate] (1.269 s) : 0, 1269128
Total [candidate] (10.894 s) : 0, 10893896
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent appsec 1.182 s 140.387 ms (13.5%)
Agent iast 1.175 s 133.996 ms (12.9%)
Agent profiling 1.256 s 214.214 ms (20.6%)
Total tracing 10.436 s -
Total appsec 10.764 s 327.838 ms (3.1%)
Total iast 10.994 s 557.846 ms (5.3%)
Total profiling 10.775 s 338.241 ms (3.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.04 s -
Agent appsec 1.182 s 141.855 ms (13.6%)
Agent iast 1.187 s 147.037 ms (14.1%)
Agent profiling 1.269 s 229.027 ms (22.0%)
Total tracing 10.433 s -
Total appsec 10.723 s 290.032 ms (2.8%)
Total iast 11.092 s 658.597 ms (6.3%)
Total profiling 10.894 s 460.776 ms (4.4%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~6bf71015f7, baseline=1.48.0-SNAPSHOT~039404dfa5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.79 ms) : 0, 716790
BytebuddyAgent [candidate] (717.465 ms) : 0, 717465
GlobalTracer [baseline] (239.983 ms) : 0, 239983
GlobalTracer [candidate] (239.62 ms) : 0, 239620
AppSec [baseline] (55.298 ms) : 0, 55298
AppSec [candidate] (55.186 ms) : 0, 55186
Remote Config [baseline] (688.239 µs) : 0, 688
Remote Config [candidate] (686.591 µs) : 0, 687
Telemetry [baseline] (13.629 ms) : 0, 13629
Telemetry [candidate] (12.224 ms) : 0, 12224
section appsec
BytebuddyAgent [baseline] (734.144 ms) : 0, 734144
BytebuddyAgent [candidate] (734.535 ms) : 0, 734535
GlobalTracer [baseline] (236.288 ms) : 0, 236288
GlobalTracer [candidate] (236.212 ms) : 0, 236212
AppSec [baseline] (176.405 ms) : 0, 176405
AppSec [candidate] (176.608 ms) : 0, 176608
Remote Config [baseline] (663.473 µs) : 0, 663
Remote Config [candidate] (655.645 µs) : 0, 656
Telemetry [baseline] (8.601 ms) : 0, 8601
Telemetry [candidate] (8.242 ms) : 0, 8242
IAST [baseline] (21.607 ms) : 0, 21607
IAST [candidate] (21.636 ms) : 0, 21636
section iast
BytebuddyAgent [baseline] (839.586 ms) : 0, 839586
BytebuddyAgent [candidate] (849.846 ms) : 0, 849846
GlobalTracer [baseline] (231.383 ms) : 0, 231383
GlobalTracer [candidate] (232.621 ms) : 0, 232621
AppSec [baseline] (57.269 ms) : 0, 57269
AppSec [candidate] (57.043 ms) : 0, 57043
Remote Config [baseline] (616.546 µs) : 0, 617
Remote Config [candidate] (624.315 µs) : 0, 624
Telemetry [baseline] (8.699 ms) : 0, 8699
Telemetry [candidate] (8.78 ms) : 0, 8780
IAST [baseline] (22.856 ms) : 0, 22856
IAST [candidate] (23.106 ms) : 0, 23106
section profiling
BytebuddyAgent [baseline] (707.274 ms) : 0, 707274
BytebuddyAgent [candidate] (713.529 ms) : 0, 713529
GlobalTracer [baseline] (347.526 ms) : 0, 347526
GlobalTracer [candidate] (352.544 ms) : 0, 352544
AppSec [baseline] (54.932 ms) : 0, 54932
AppSec [candidate] (54.865 ms) : 0, 54865
Remote Config [baseline] (671.601 µs) : 0, 672
Remote Config [candidate] (673.071 µs) : 0, 673
Telemetry [baseline] (8.916 ms) : 0, 8916
Telemetry [candidate] (9.033 ms) : 0, 9033
ProfilingAgent [baseline] (96.031 ms) : 0, 96031
ProfilingAgent [candidate] (97.753 ms) : 0, 97753
Profiling [baseline] (96.057 ms) : 0, 96057
Profiling [candidate] (97.777 ms) : 0, 97777
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-05T19:37:27 2025-03-05T19:45:12
git_branch master mcculls/prefer-closeActive-to-activeScope.close
git_commit_date 1741201628 1741202768
git_commit_sha 039404d 6bf7101
release_version 1.48.0-SNAPSHOT~039404dfa5 1.48.0-SNAPSHOT~6bf71015f7
start_time 2025-03-05T19:37:13 2025-03-05T19:44:59
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741204309 1741204309
ci_job_id 834479540 834479540
ci_pipeline_id 57840964 57840964
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-1pycrazx-project-304-concurrent-0-fce23kjr 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-1pycrazx-project-304-concurrent-0-fce23kjr 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~6bf71015f7, baseline=1.48.0-SNAPSHOT~039404dfa5
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.142 µs) : 356, 396
.   : milestone, 376,
iast (509.696 µs) : 488, 531
.   : milestone, 510,
iast_FULL (733.134 µs) : 711, 755
.   : milestone, 733,
iast_GLOBAL (558.207 µs) : 536, 581
.   : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (512.185 µs) : 490, 535
.   : milestone, 512,
iast_INACTIVE (464.735 µs) : 443, 487
.   : milestone, 465,
iast_TELEMETRY_OFF (495.463 µs) : 473, 518
.   : milestone, 495,
tracing (464.474 µs) : 443, 486
.   : milestone, 464,
section candidate
no_agent (381.328 µs) : 362, 401
.   : milestone, 381,
iast (503.564 µs) : 482, 525
.   : milestone, 504,
iast_FULL (730.902 µs) : 709, 753
.   : milestone, 731,
iast_GLOBAL (559.49 µs) : 538, 581
.   : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (510.882 µs) : 488, 534
.   : milestone, 511,
iast_INACTIVE (460.77 µs) : 439, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (500.319 µs) : 478, 523
.   : milestone, 500,
tracing (454.657 µs) : 434, 475
.   : milestone, 455,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.142 µs [356.003 µs, 396.281 µs] -
iast 509.696 µs [488.171 µs, 531.221 µs] 133.554 µs (35.5%)
iast_FULL 733.134 µs [711.206 µs, 755.062 µs] 356.992 µs (94.9%)
iast_GLOBAL 558.207 µs [535.893 µs, 580.522 µs] 182.066 µs (48.4%)
iast_HARDCODED_SECRET_DISABLED 512.185 µs [489.822 µs, 534.548 µs] 136.043 µs (36.2%)
iast_INACTIVE 464.735 µs [442.874 µs, 486.596 µs] 88.593 µs (23.6%)
iast_TELEMETRY_OFF 495.463 µs [472.652 µs, 518.273 µs] 119.321 µs (31.7%)
tracing 464.474 µs [443.153 µs, 485.795 µs] 88.332 µs (23.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.328 µs [361.741 µs, 400.916 µs] -
iast 503.564 µs [482.017 µs, 525.11 µs] 122.235 µs (32.1%)
iast_FULL 730.902 µs [708.824 µs, 752.98 µs] 349.573 µs (91.7%)
iast_GLOBAL 559.49 µs [537.752 µs, 581.228 µs] 178.161 µs (46.7%)
iast_HARDCODED_SECRET_DISABLED 510.882 µs [488.133 µs, 533.631 µs] 129.554 µs (34.0%)
iast_INACTIVE 460.77 µs [439.496 µs, 482.044 µs] 79.442 µs (20.8%)
iast_TELEMETRY_OFF 500.319 µs [477.733 µs, 522.906 µs] 118.991 µs (31.2%)
tracing 454.657 µs [434.044 µs, 475.27 µs] 73.329 µs (19.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~6bf71015f7, baseline=1.48.0-SNAPSHOT~039404dfa5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.363 ms) : 1344, 1382
.   : milestone, 1363,
appsec (1.73 ms) : 1706, 1754
.   : milestone, 1730,
appsec_no_iast (1.71 ms) : 1686, 1734
.   : milestone, 1710,
code_origins (1.679 ms) : 1645, 1713
.   : milestone, 1679,
iast (1.51 ms) : 1486, 1533
.   : milestone, 1510,
profiling (1.511 ms) : 1487, 1534
.   : milestone, 1511,
tracing (1.473 ms) : 1448, 1498
.   : milestone, 1473,
section candidate
no_agent (1.355 ms) : 1335, 1375
.   : milestone, 1355,
appsec (1.716 ms) : 1692, 1739
.   : milestone, 1716,
appsec_no_iast (1.732 ms) : 1706, 1757
.   : milestone, 1732,
code_origins (1.671 ms) : 1637, 1704
.   : milestone, 1671,
iast (1.504 ms) : 1480, 1527
.   : milestone, 1504,
profiling (1.531 ms) : 1507, 1555
.   : milestone, 1531,
tracing (1.48 ms) : 1455, 1504
.   : milestone, 1480,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.344 ms, 1.382 ms] -
appsec 1.73 ms [1.706 ms, 1.754 ms] 366.691 µs (26.9%)
appsec_no_iast 1.71 ms [1.686 ms, 1.734 ms] 346.834 µs (25.4%)
code_origins 1.679 ms [1.645 ms, 1.713 ms] 316.103 µs (23.2%)
iast 1.51 ms [1.486 ms, 1.533 ms] 146.924 µs (10.8%)
profiling 1.511 ms [1.487 ms, 1.534 ms] 147.604 µs (10.8%)
tracing 1.473 ms [1.448 ms, 1.498 ms] 109.934 µs (8.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.335 ms, 1.375 ms] -
appsec 1.716 ms [1.692 ms, 1.739 ms] 360.788 µs (26.6%)
appsec_no_iast 1.732 ms [1.706 ms, 1.757 ms] 376.687 µs (27.8%)
code_origins 1.671 ms [1.637 ms, 1.704 ms] 315.591 µs (23.3%)
iast 1.504 ms [1.48 ms, 1.527 ms] 148.568 µs (11.0%)
profiling 1.531 ms [1.507 ms, 1.555 ms] 175.789 µs (13.0%)
tracing 1.48 ms [1.455 ms, 1.504 ms] 124.513 µs (9.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/prefer-closeActive-to-activeScope.close
git_commit_date 1741201628 1741202768
git_commit_sha 039404d 6bf7101
release_version 1.48.0-SNAPSHOT~039404dfa5 1.48.0-SNAPSHOT~6bf71015f7
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1741204754 1741204754
ci_job_id 834479541 834479541
ci_pipeline_id 57840964 57840964
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-snmtyxn8-project-304-concurrent-5-0ayfdwt9 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-snmtyxn8-project-304-concurrent-5-0ayfdwt9 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~6bf71015f7, baseline=1.48.0-SNAPSHOT~039404dfa5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.325 ms) : 2281, 2368
.   : milestone, 2325,
iast (2.122 ms) : 2067, 2177
.   : milestone, 2122,
iast_GLOBAL (2.162 ms) : 2106, 2217
.   : milestone, 2162,
profiling (2.435 ms) : 2255, 2615
.   : milestone, 2435,
tracing (1.941 ms) : 1899, 1982
.   : milestone, 1941,
section candidate
no_agent (1.475 ms) : 1463, 1487
.   : milestone, 1475,
appsec (2.347 ms) : 2303, 2391
.   : milestone, 2347,
iast (2.118 ms) : 2063, 2173
.   : milestone, 2118,
iast_GLOBAL (2.157 ms) : 2102, 2213
.   : milestone, 2157,
profiling (1.969 ms) : 1925, 2012
.   : milestone, 1969,
tracing (1.951 ms) : 1909, 1993
.   : milestone, 1951,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 2.325 ms [2.281 ms, 2.368 ms] 852.624 µs (57.9%)
iast 2.122 ms [2.067 ms, 2.177 ms] 649.536 µs (44.1%)
iast_GLOBAL 2.162 ms [2.106 ms, 2.217 ms] 689.549 µs (46.8%)
profiling 2.435 ms [2.255 ms, 2.615 ms] 962.843 µs (65.4%)
tracing 1.941 ms [1.899 ms, 1.982 ms] 468.45 µs (31.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.487 ms] -
appsec 2.347 ms [2.303 ms, 2.391 ms] 871.918 µs (59.1%)
iast 2.118 ms [2.063 ms, 2.173 ms] 642.932 µs (43.6%)
iast_GLOBAL 2.157 ms [2.102 ms, 2.213 ms] 682.267 µs (46.3%)
profiling 1.969 ms [1.925 ms, 2.012 ms] 493.69 µs (33.5%)
tracing 1.951 ms [1.909 ms, 1.993 ms] 475.761 µs (32.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~6bf71015f7, baseline=1.48.0-SNAPSHOT~039404dfa5
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.823 s) : 14823000, 14823000
.   : milestone, 14823000,
appsec (15.077 s) : 15077000, 15077000
.   : milestone, 15077000,
iast (18.855 s) : 18855000, 18855000
.   : milestone, 18855000,
iast_GLOBAL (18.054 s) : 18054000, 18054000
.   : milestone, 18054000,
profiling (15.154 s) : 15154000, 15154000
.   : milestone, 15154000,
tracing (14.901 s) : 14901000, 14901000
.   : milestone, 14901000,
section candidate
no_agent (14.816 s) : 14816000, 14816000
.   : milestone, 14816000,
appsec (15.107 s) : 15107000, 15107000
.   : milestone, 15107000,
iast (18.516 s) : 18516000, 18516000
.   : milestone, 18516000,
iast_GLOBAL (18.289 s) : 18289000, 18289000
.   : milestone, 18289000,
profiling (15.11 s) : 15110000, 15110000
.   : milestone, 15110000,
tracing (15.0 s) : 15000000, 15000000
.   : milestone, 15000000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.823 s [14.823 s, 14.823 s] -
appsec 15.077 s [15.077 s, 15.077 s] 254.0 ms (1.7%)
iast 18.855 s [18.855 s, 18.855 s] 4.032 s (27.2%)
iast_GLOBAL 18.054 s [18.054 s, 18.054 s] 3.231 s (21.8%)
profiling 15.154 s [15.154 s, 15.154 s] 331.0 ms (2.2%)
tracing 14.901 s [14.901 s, 14.901 s] 78.0 ms (0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.816 s [14.816 s, 14.816 s] -
appsec 15.107 s [15.107 s, 15.107 s] 291.0 ms (2.0%)
iast 18.516 s [18.516 s, 18.516 s] 3.7 s (25.0%)
iast_GLOBAL 18.289 s [18.289 s, 18.289 s] 3.473 s (23.4%)
profiling 15.11 s [15.11 s, 15.11 s] 294.0 ms (2.0%)
tracing 15.0 s [15.0 s, 15.0 s] 184.0 ms (1.2%)

@mcculls mcculls marked this pull request as ready for review March 4, 2025 15:32
@mcculls mcculls requested review from a team as code owners March 4, 2025 15:32
amarziali
amarziali approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok. Thanks for the new API

PerfectSlayer
PerfectSlayer approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Left few comments about the original code comments

@mcculls mcculls force-pushed the mcculls/remove-active-scope-usage branch from 05b7f22 to f6e8b55 Compare March 5, 2025 16:13
@mcculls mcculls requested a review from a team as a code owner March 5, 2025 16:13
@mcculls mcculls requested a review from dougqh March 5, 2025 16:13
@mcculls mcculls force-pushed the mcculls/prefer-closeActive-to-activeScope.close branch from 41640fe to 0e24550 Compare March 5, 2025 16:20
Base automatically changed from mcculls/remove-active-scope-usage to master March 5, 2025 19:07
@mcculls mcculls force-pushed the mcculls/prefer-closeActive-to-activeScope.close branch from 0e24550 to 9603115 Compare March 5, 2025 19:11
@mcculls mcculls force-pushed the mcculls/prefer-closeActive-to-activeScope.close branch from 9603115 to 6bf7101 Compare March 5, 2025 19:26
@mcculls mcculls merged commit 516cb80 into master Mar 5, 2025
209 checks passed
@mcculls mcculls deleted the mcculls/prefer-closeActive-to-activeScope.close branch March 5, 2025 21:46
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@amarziali amarziali amarziali approved these changes

@nikita-tkachenko-datadog nikita-tkachenko-datadog Awaiting requested review from nikita-tkachenko-datadog nikita-tkachenko-datadog is a code owner automatically assigned from DataDog/ci-app-libraries-java

@dougqh dougqh Awaiting requested review from dougqh dougqh was automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
inst: others All other instrumentations tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mcculls @PerfectSlayer @amarziali