Remove activeScope() use in OpenTracing shim #8478

mcculls · 2025-02-28T22:18:37Z

Motivation

This was only used to implement the deprecated 'active()' OpenTracing method. We take a best effort approach of using a 'fake' scope which lets the caller close the active scope if it matches the expected span, and otherwise logs a warning (or throws an exception in strict mode.)

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-956

pr-commenter · 2025-02-28T23:03:27Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/remove-active-scope-usage
git_commit_date	1741182994	1741191188
git_commit_sha	`6055d50`	`f6e8b55`
release_version	1.48.0-SNAPSHOT~6055d50b80	1.48.0-SNAPSHOT~f6e8b5563d

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1741193704	1741193704
ci_job_id	834048990	834048990
ci_pipeline_id	57812100	57812100
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-ys3prsmt-project-304-concurrent-0-kxdtfuxr 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-ys3prsmt-project-304-concurrent-0-kxdtfuxr 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~f6e8b5563d, baseline=1.48.0-SNAPSHOT~6055d50b80

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049744
Total [baseline] (8.667 s) : 0, 8667259
Agent [candidate] (1.053 s) : 0, 1052682
Total [candidate] (8.672 s) : 0, 8671982
section iast
Agent [baseline] (1.168 s) : 0, 1168374
Total [baseline] (9.216 s) : 0, 9216464
Agent [candidate] (1.17 s) : 0, 1169979
Total [candidate] (9.235 s) : 0, 9235208
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1173523
Total [baseline] (9.207 s) : 0, 9207280
Agent [candidate] (1.173 s) : 0, 1173311
Total [candidate] (9.195 s) : 0, 9194580
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1162923
Total [baseline] (9.262 s) : 0, 9262376
Agent [candidate] (1.166 s) : 0, 1165772
Total [candidate] (9.235 s) : 0, 9234507

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	iast	1.168 s	118.63 ms (11.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.174 s	123.778 ms (11.8%)
Agent	iast_TELEMETRY_OFF	1.163 s	113.179 ms (10.8%)
Total	tracing	8.667 s	-
Total	iast	9.216 s	549.205 ms (6.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.207 s	540.021 ms (6.2%)
Total	iast_TELEMETRY_OFF	9.262 s	595.117 ms (6.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.053 s	-
Agent	iast	1.17 s	117.297 ms (11.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.173 s	120.629 ms (11.5%)
Agent	iast_TELEMETRY_OFF	1.166 s	113.091 ms (10.7%)
Total	tracing	8.672 s	-
Total	iast	9.235 s	563.226 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.195 s	522.598 ms (6.0%)
Total	iast_TELEMETRY_OFF	9.235 s	562.525 ms (6.5%)

gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~f6e8b5563d, baseline=1.48.0-SNAPSHOT~6055d50b80

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (725.767 ms) : 0, 725767
BytebuddyAgent [candidate] (726.781 ms) : 0, 726781
GlobalTracer [baseline] (240.485 ms) : 0, 240485
GlobalTracer [candidate] (242.382 ms) : 0, 242382
AppSec [baseline] (55.399 ms) : 0, 55399
AppSec [candidate] (55.95 ms) : 0, 55950
Remote Config [baseline] (703.196 µs) : 0, 703
Remote Config [candidate] (714.048 µs) : 0, 714
Telemetry [baseline] (12.24 ms) : 0, 12240
Telemetry [candidate] (11.665 ms) : 0, 11665
section iast
BytebuddyAgent [baseline] (834.727 ms) : 0, 834727
BytebuddyAgent [candidate] (835.655 ms) : 0, 835655
GlobalTracer [baseline] (229.519 ms) : 0, 229519
GlobalTracer [candidate] (230.479 ms) : 0, 230479
IAST [baseline] (22.775 ms) : 0, 22775
IAST [candidate] (22.727 ms) : 0, 22727
AppSec [baseline] (57.144 ms) : 0, 57144
AppSec [candidate] (56.906 ms) : 0, 56906
Remote Config [baseline] (615.468 µs) : 0, 615
Remote Config [candidate] (616.412 µs) : 0, 616
Telemetry [baseline] (8.646 ms) : 0, 8646
Telemetry [candidate] (8.626 ms) : 0, 8626
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.742 ms) : 0, 839742
BytebuddyAgent [candidate] (837.845 ms) : 0, 837845
GlobalTracer [baseline] (229.86 ms) : 0, 229860
GlobalTracer [candidate] (231.047 ms) : 0, 231047
IAST [baseline] (22.874 ms) : 0, 22874
IAST [candidate] (22.992 ms) : 0, 22992
AppSec [baseline] (56.714 ms) : 0, 56714
AppSec [candidate] (57.08 ms) : 0, 57080
Remote Config [baseline] (610.386 µs) : 0, 610
Remote Config [candidate] (614.301 µs) : 0, 614
Telemetry [baseline] (8.663 ms) : 0, 8663
Telemetry [candidate] (8.722 ms) : 0, 8722
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.279 ms) : 0, 830279
BytebuddyAgent [candidate] (832.091 ms) : 0, 832091
GlobalTracer [baseline] (229.638 ms) : 0, 229638
GlobalTracer [candidate] (230.318 ms) : 0, 230318
IAST [baseline] (23.048 ms) : 0, 23048
IAST [candidate] (23.051 ms) : 0, 23051
AppSec [baseline] (55.849 ms) : 0, 55849
AppSec [candidate] (56.088 ms) : 0, 56088
Remote Config [baseline] (597.314 µs) : 0, 597
Remote Config [candidate] (607.825 µs) : 0, 608
Telemetry [baseline] (8.557 ms) : 0, 8557
Telemetry [candidate] (8.661 ms) : 0, 8661

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~f6e8b5563d, baseline=1.48.0-SNAPSHOT~6055d50b80

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.037 s) : 0, 1037354
Total [baseline] (10.414 s) : 0, 10413955
Agent [candidate] (1.047 s) : 0, 1046571
Total [candidate] (10.554 s) : 0, 10553631
section appsec
Agent [baseline] (1.183 s) : 0, 1182814
Total [baseline] (10.758 s) : 0, 10757532
Agent [candidate] (1.187 s) : 0, 1186833
Total [candidate] (10.747 s) : 0, 10746708
section iast
Agent [baseline] (1.171 s) : 0, 1171152
Total [baseline] (10.991 s) : 0, 10990631
Agent [candidate] (1.169 s) : 0, 1169416
Total [candidate] (10.987 s) : 0, 10987080
section profiling
Agent [baseline] (1.261 s) : 0, 1260971
Total [baseline] (10.854 s) : 0, 10853676
Agent [candidate] (1.266 s) : 0, 1265529
Total [candidate] (10.878 s) : 0, 10878184

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.037 s	-
Agent	appsec	1.183 s	145.46 ms (14.0%)
Agent	iast	1.171 s	133.798 ms (12.9%)
Agent	profiling	1.261 s	223.617 ms (21.6%)
Total	tracing	10.414 s	-
Total	appsec	10.758 s	343.577 ms (3.3%)
Total	iast	10.991 s	576.675 ms (5.5%)
Total	profiling	10.854 s	439.721 ms (4.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	appsec	1.187 s	140.262 ms (13.4%)
Agent	iast	1.169 s	122.845 ms (11.7%)
Agent	profiling	1.266 s	218.957 ms (20.9%)
Total	tracing	10.554 s	-
Total	appsec	10.747 s	193.077 ms (1.8%)
Total	iast	10.987 s	433.449 ms (4.1%)
Total	profiling	10.878 s	324.553 ms (3.1%)

gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~f6e8b5563d, baseline=1.48.0-SNAPSHOT~6055d50b80

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.185 ms) : 0, 716185
BytebuddyAgent [candidate] (722.083 ms) : 0, 722083
GlobalTracer [baseline] (239.148 ms) : 0, 239148
GlobalTracer [candidate] (241.111 ms) : 0, 241111
AppSec [baseline] (55.015 ms) : 0, 55015
AppSec [candidate] (55.369 ms) : 0, 55369
Remote Config [baseline] (686.729 µs) : 0, 687
Remote Config [candidate] (692.491 µs) : 0, 692
Telemetry [baseline] (11.351 ms) : 0, 11351
Telemetry [candidate] (12.219 ms) : 0, 12219
section appsec
BytebuddyAgent [baseline] (735.002 ms) : 0, 735002
BytebuddyAgent [candidate] (736.802 ms) : 0, 736802
GlobalTracer [baseline] (236.362 ms) : 0, 236362
GlobalTracer [candidate] (237.418 ms) : 0, 237418
IAST [baseline] (21.438 ms) : 0, 21438
IAST [candidate] (21.393 ms) : 0, 21393
AppSec [baseline] (176.904 ms) : 0, 176904
AppSec [candidate] (177.944 ms) : 0, 177944
Remote Config [baseline] (656.971 µs) : 0, 657
Remote Config [candidate] (676.987 µs) : 0, 677
Telemetry [baseline] (8.235 ms) : 0, 8235
Telemetry [candidate] (8.315 ms) : 0, 8315
section iast
BytebuddyAgent [baseline] (836.713 ms) : 0, 836713
BytebuddyAgent [candidate] (835.809 ms) : 0, 835809
GlobalTracer [baseline] (230.057 ms) : 0, 230057
GlobalTracer [candidate] (229.937 ms) : 0, 229937
IAST [baseline] (23.699 ms) : 0, 23699
IAST [candidate] (22.737 ms) : 0, 22737
AppSec [baseline] (56.344 ms) : 0, 56344
AppSec [candidate] (56.759 ms) : 0, 56759
Remote Config [baseline] (625.322 µs) : 0, 625
Remote Config [candidate] (615.056 µs) : 0, 615
Telemetry [baseline] (8.758 ms) : 0, 8758
Telemetry [candidate] (8.582 ms) : 0, 8582
section profiling
BytebuddyAgent [baseline] (709.792 ms) : 0, 709792
BytebuddyAgent [candidate] (712.273 ms) : 0, 712273
GlobalTracer [baseline] (350.082 ms) : 0, 350082
GlobalTracer [candidate] (351.915 ms) : 0, 351915
AppSec [baseline] (54.708 ms) : 0, 54708
AppSec [candidate] (54.315 ms) : 0, 54315
Remote Config [baseline] (674.383 µs) : 0, 674
Remote Config [candidate] (672.74 µs) : 0, 673
Telemetry [baseline] (8.915 ms) : 0, 8915
Telemetry [candidate] (8.959 ms) : 0, 8959
ProfilingAgent [baseline] (96.356 ms) : 0, 96356
ProfilingAgent [candidate] (96.776 ms) : 0, 96776
Profiling [baseline] (96.382 ms) : 0, 96382
Profiling [candidate] (96.8 ms) : 0, 96800

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-03-05T16:25:30	2025-03-05T16:33:16
git_branch	master	mcculls/remove-active-scope-usage
git_commit_date	1741182994	1741191188
git_commit_sha	`6055d50`	`f6e8b55`
release_version	1.48.0-SNAPSHOT~6055d50b80	1.48.0-SNAPSHOT~f6e8b5563d
start_time	2025-03-05T16:25:16	2025-03-05T16:33:02

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1741192795	1741192795
ci_job_id	834048992	834048992
ci_pipeline_id	57812100	57812100
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-ys3prsmt-project-304-concurrent-1-vbwyn266 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-ys3prsmt-project-304-concurrent-1-vbwyn266 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~f6e8b5563d, baseline=1.48.0-SNAPSHOT~6055d50b80
    dateFormat X
    axisFormat %s
section baseline
no_agent (382.38 µs) : 362, 403
.   : milestone, 382,
iast (518.267 µs) : 496, 541
.   : milestone, 518,
iast_FULL (729.674 µs) : 708, 752
.   : milestone, 730,
iast_GLOBAL (555.613 µs) : 534, 577
.   : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (512.482 µs) : 491, 534
.   : milestone, 512,
iast_INACTIVE (469.833 µs) : 448, 491
.   : milestone, 470,
iast_TELEMETRY_OFF (503.016 µs) : 481, 525
.   : milestone, 503,
tracing (464.816 µs) : 443, 487
.   : milestone, 465,
section candidate
no_agent (390.025 µs) : 370, 410
.   : milestone, 390,
iast (517.123 µs) : 495, 539
.   : milestone, 517,
iast_FULL (732.333 µs) : 710, 754
.   : milestone, 732,
iast_GLOBAL (559.983 µs) : 538, 582
.   : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (513.508 µs) : 492, 535
.   : milestone, 514,
iast_INACTIVE (468.89 µs) : 446, 492
.   : milestone, 469,
iast_TELEMETRY_OFF (505.245 µs) : 482, 528
.   : milestone, 505,
tracing (454.299 µs) : 434, 475
.   : milestone, 454,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	382.38 µs [361.766 µs, 402.993 µs]	-
iast	518.267 µs [495.989 µs, 540.545 µs]	135.887 µs (35.5%)
iast_FULL	729.674 µs [707.73 µs, 751.618 µs]	347.294 µs (90.8%)
iast_GLOBAL	555.613 µs [534.082 µs, 577.144 µs]	173.233 µs (45.3%)
iast_HARDCODED_SECRET_DISABLED	512.482 µs [490.674 µs, 534.291 µs]	130.103 µs (34.0%)
iast_INACTIVE	469.833 µs [448.3 µs, 491.365 µs]	87.453 µs (22.9%)
iast_TELEMETRY_OFF	503.016 µs [481.333 µs, 524.699 µs]	120.636 µs (31.5%)
tracing	464.816 µs [443.01 µs, 486.622 µs]	82.436 µs (21.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	390.025 µs [370.131 µs, 409.918 µs]	-
iast	517.123 µs [495.451 µs, 538.795 µs]	127.098 µs (32.6%)
iast_FULL	732.333 µs [710.453 µs, 754.213 µs]	342.308 µs (87.8%)
iast_GLOBAL	559.983 µs [538.314 µs, 581.653 µs]	169.959 µs (43.6%)
iast_HARDCODED_SECRET_DISABLED	513.508 µs [491.853 µs, 535.162 µs]	123.483 µs (31.7%)
iast_INACTIVE	468.89 µs [446.255 µs, 491.525 µs]	78.865 µs (20.2%)
iast_TELEMETRY_OFF	505.245 µs [482.24 µs, 528.249 µs]	115.22 µs (29.5%)
tracing	454.299 µs [433.894 µs, 474.704 µs]	64.274 µs (16.5%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~f6e8b5563d, baseline=1.48.0-SNAPSHOT~6055d50b80
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.357 ms) : 1338, 1376
.   : milestone, 1357,
appsec (1.748 ms) : 1724, 1771
.   : milestone, 1748,
appsec_no_iast (1.742 ms) : 1717, 1766
.   : milestone, 1742,
code_origins (1.675 ms) : 1642, 1708
.   : milestone, 1675,
iast (1.518 ms) : 1494, 1542
.   : milestone, 1518,
profiling (1.559 ms) : 1533, 1584
.   : milestone, 1559,
tracing (1.508 ms) : 1483, 1532
.   : milestone, 1508,
section candidate
no_agent (1.343 ms) : 1323, 1362
.   : milestone, 1343,
appsec (1.737 ms) : 1713, 1761
.   : milestone, 1737,
appsec_no_iast (1.731 ms) : 1706, 1756
.   : milestone, 1731,
code_origins (1.688 ms) : 1655, 1721
.   : milestone, 1688,
iast (1.51 ms) : 1487, 1534
.   : milestone, 1510,
profiling (1.563 ms) : 1538, 1588
.   : milestone, 1563,
tracing (1.507 ms) : 1483, 1531
.   : milestone, 1507,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.357 ms [1.338 ms, 1.376 ms]	-
appsec	1.748 ms [1.724 ms, 1.771 ms]	390.675 µs (28.8%)
appsec_no_iast	1.742 ms [1.717 ms, 1.766 ms]	384.663 µs (28.3%)
code_origins	1.675 ms [1.642 ms, 1.708 ms]	317.792 µs (23.4%)
iast	1.518 ms [1.494 ms, 1.542 ms]	161.092 µs (11.9%)
profiling	1.559 ms [1.533 ms, 1.584 ms]	201.522 µs (14.8%)
tracing	1.508 ms [1.483 ms, 1.532 ms]	150.522 µs (11.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.343 ms [1.323 ms, 1.362 ms]	-
appsec	1.737 ms [1.713 ms, 1.761 ms]	393.984 µs (29.3%)
appsec_no_iast	1.731 ms [1.706 ms, 1.756 ms]	388.579 µs (28.9%)
code_origins	1.688 ms [1.655 ms, 1.721 ms]	345.327 µs (25.7%)
iast	1.51 ms [1.487 ms, 1.534 ms]	167.873 µs (12.5%)
profiling	1.563 ms [1.538 ms, 1.588 ms]	220.539 µs (16.4%)
tracing	1.507 ms [1.483 ms, 1.531 ms]	164.16 µs (12.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/remove-active-scope-usage
git_commit_date	1741182994	1741191188
git_commit_sha	`6055d50`	`f6e8b55`
release_version	1.48.0-SNAPSHOT~6055d50b80	1.48.0-SNAPSHOT~f6e8b5563d

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1741193053	1741193053
ci_job_id	834048993	834048993
ci_pipeline_id	57812100	57812100
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-snmtyxn8-project-304-concurrent-0-lnvzdykx 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-snmtyxn8-project-304-concurrent-0-lnvzdykx 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~f6e8b5563d, baseline=1.48.0-SNAPSHOT~6055d50b80
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.322 ms) : 2279, 2365
.   : milestone, 2322,
iast (2.101 ms) : 2047, 2156
.   : milestone, 2101,
iast_GLOBAL (2.152 ms) : 2097, 2207
.   : milestone, 2152,
profiling (1.979 ms) : 1934, 2023
.   : milestone, 1979,
tracing (1.94 ms) : 1898, 1982
.   : milestone, 1940,
section candidate
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.332 ms) : 2289, 2375
.   : milestone, 2332,
iast (2.104 ms) : 2049, 2159
.   : milestone, 2104,
iast_GLOBAL (2.154 ms) : 2099, 2210
.   : milestone, 2154,
profiling (1.957 ms) : 1914, 2001
.   : milestone, 1957,
tracing (1.934 ms) : 1893, 1976
.   : milestone, 1934,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.463 ms [1.451 ms, 1.474 ms]	-
appsec	2.322 ms [2.279 ms, 2.365 ms]	858.924 µs (58.7%)
iast	2.101 ms [2.047 ms, 2.156 ms]	638.469 µs (43.6%)
iast_GLOBAL	2.152 ms [2.097 ms, 2.207 ms]	689.264 µs (47.1%)
profiling	1.979 ms [1.934 ms, 2.023 ms]	515.773 µs (35.3%)
tracing	1.94 ms [1.898 ms, 1.982 ms]	477.229 µs (32.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.461 ms, 1.484 ms]	-
appsec	2.332 ms [2.289 ms, 2.375 ms]	859.463 µs (58.4%)
iast	2.104 ms [2.049 ms, 2.159 ms]	631.53 µs (42.9%)
iast_GLOBAL	2.154 ms [2.099 ms, 2.21 ms]	681.899 µs (46.3%)
profiling	1.957 ms [1.914 ms, 2.001 ms]	484.929 µs (32.9%)
tracing	1.934 ms [1.893 ms, 1.976 ms]	461.924 µs (31.4%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~f6e8b5563d, baseline=1.48.0-SNAPSHOT~6055d50b80
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.735 s) : 14735000, 14735000
.   : milestone, 14735000,
appsec (14.991 s) : 14991000, 14991000
.   : milestone, 14991000,
iast (18.642 s) : 18642000, 18642000
.   : milestone, 18642000,
iast_GLOBAL (17.441 s) : 17441000, 17441000
.   : milestone, 17441000,
profiling (14.922 s) : 14922000, 14922000
.   : milestone, 14922000,
tracing (14.999 s) : 14999000, 14999000
.   : milestone, 14999000,
section candidate
no_agent (15.405 s) : 15405000, 15405000
.   : milestone, 15405000,
appsec (15.159 s) : 15159000, 15159000
.   : milestone, 15159000,
iast (18.339 s) : 18339000, 18339000
.   : milestone, 18339000,
iast_GLOBAL (17.774 s) : 17774000, 17774000
.   : milestone, 17774000,
profiling (14.963 s) : 14963000, 14963000
.   : milestone, 14963000,
tracing (14.95 s) : 14950000, 14950000
.   : milestone, 14950000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.735 s [14.735 s, 14.735 s]	-
appsec	14.991 s [14.991 s, 14.991 s]	256.0 ms (1.7%)
iast	18.642 s [18.642 s, 18.642 s]	3.907 s (26.5%)
iast_GLOBAL	17.441 s [17.441 s, 17.441 s]	2.706 s (18.4%)
profiling	14.922 s [14.922 s, 14.922 s]	187.0 ms (1.3%)
tracing	14.999 s [14.999 s, 14.999 s]	264.0 ms (1.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.405 s [15.405 s, 15.405 s]	-
appsec	15.159 s [15.159 s, 15.159 s]	-246.0 ms (-1.6%)
iast	18.339 s [18.339 s, 18.339 s]	2.934 s (19.0%)
iast_GLOBAL	17.774 s [17.774 s, 17.774 s]	2.369 s (15.4%)
profiling	14.963 s [14.963 s, 14.963 s]	-442.0 ms (-2.9%)
tracing	14.95 s [14.95 s, 14.95 s]	-455.0 ms (-3.0%)

amarziali

lgtm for idm

PerfectSlayer

Few comments to discuss about the API. Nothing blocking.

internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentTracer.java

...acing/api-0.31/src/main/java/datadog/trace/instrumentation/opentracing31/OTScopeManager.java

internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentTracer.java

PerfectSlayer

Thanks a lot for your updates and considering all my nitpicks! 🙇

mcculls · 2025-03-04T10:55:00Z

No problem, thanks for the suggestions!

This was only used to implement the deprecated 'active()' OpenTracing method. We take a best effort approach of using a 'fake' scope which lets the caller close the active scope if it matches the expected span, and otherwise logs a warning (or throws an exception in strict mode.)

mcculls added tag: do not merge Do not merge changes comp: core Tracer core type: refactoring labels Feb 28, 2025

mcculls force-pushed the mcculls/remove-active-scope-usage branch 7 times, most recently from 9bbbcd9 to d824901 Compare March 3, 2025 14:29

mcculls changed the title ~~WIP - remove remaining activeScope() calls from instrumentation~~ Remove activeScope() use in OpenTracing shim Mar 3, 2025

mcculls added comp: opentracing OpenTracing and removed tag: do not merge Do not merge changes comp: core Tracer core labels Mar 3, 2025

mcculls marked this pull request as ready for review March 3, 2025 15:20

mcculls requested review from a team as code owners March 3, 2025 15:20

mcculls requested review from smola and PerfectSlayer March 3, 2025 15:20

mcculls force-pushed the mcculls/remove-active-scope-usage branch 2 times, most recently from f451c53 to 6e3d064 Compare March 3, 2025 21:48

smola requested review from a team and removed request for smola and a team March 4, 2025 08:36

amarziali approved these changes Mar 4, 2025

View reviewed changes

PerfectSlayer reviewed Mar 4, 2025

View reviewed changes

mcculls force-pushed the mcculls/remove-active-scope-usage branch from 4f90af6 to 05b7f22 Compare March 4, 2025 10:46

PerfectSlayer approved these changes Mar 4, 2025

View reviewed changes

mcculls mentioned this pull request Mar 4, 2025

Migrate certain instrumentations to use closeActive() to close outstanding spans #8503

Merged

mcculls added 3 commits March 5, 2025 16:13

feedback

4dfb8e9

include span in log/exception

f6e8b55

mcculls force-pushed the mcculls/remove-active-scope-usage branch from 05b7f22 to f6e8b55 Compare March 5, 2025 16:13

mcculls merged commit 039404d into master Mar 5, 2025
209 checks passed

mcculls deleted the mcculls/remove-active-scope-usage branch March 5, 2025 19:07

github-actions bot added this to the 1.48.0 milestone Mar 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove activeScope() use in OpenTracing shim #8478

Remove activeScope() use in OpenTracing shim #8478

mcculls commented Feb 28, 2025 •

edited

Loading

pr-commenter bot commented Feb 28, 2025 •

edited

Loading

amarziali left a comment

PerfectSlayer left a comment

PerfectSlayer left a comment

mcculls commented Mar 4, 2025

Remove activeScope() use in OpenTracing shim #8478

Remove activeScope() use in OpenTracing shim #8478

Conversation

mcculls commented Feb 28, 2025 • edited Loading

Motivation

Contributor Checklist

pr-commenter bot commented Feb 28, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

amarziali left a comment

Choose a reason for hiding this comment

PerfectSlayer left a comment

Choose a reason for hiding this comment

PerfectSlayer left a comment

Choose a reason for hiding this comment

mcculls commented Mar 4, 2025

mcculls commented Feb 28, 2025 •

edited

Loading

pr-commenter bot commented Feb 28, 2025 •

edited

Loading