Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: fix issue extracting B3 tracing ID of 128 bits #780

Merged
merged 4 commits into from
Nov 19, 2020

Conversation

stroem
Copy link
Contributor

@stroem stroem commented Nov 18, 2020

Current solution were only supporting parsing 16 encoded lower-hex characters.
Update make sure the take the last characters before parsing, fixing the issue.

Fixes for issue #779

Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is fine, but let's add some tests for it too please.

ddtrace/tracer/textmap.go Outdated Show resolved Hide resolved
@gbbr gbbr changed the title Fixed issue extracting b3 tracing id of 128 bits ddtrace/tracer: fix issue extracting B3 tracing ID of 128 bits Nov 18, 2020
@gbbr gbbr added this to the 1.28.0 milestone Nov 18, 2020
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you! One last thing, small nit

ddtrace/tracer/textmap_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience 🙂

@gbbr gbbr merged commit b9e8e8c into DataDog:v1 Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants