Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for extracting b3 propagation trace id with 128 bits #779

Closed
stroem opened this issue Nov 18, 2020 · 3 comments
Closed

Support for extracting b3 propagation trace id with 128 bits #779

stroem opened this issue Nov 18, 2020 · 3 comments

Comments

@stroem
Copy link
Contributor

stroem commented Nov 18, 2020

When I try to extract a b3 tracing id of len 32 (128 bits) it fails to parse it.

ctx.traceID, err = strconv.ParseUint(v, 16, 64)

Reading the specification for the headers it states that the X-B3-TraceId header is encoded as 32 or 16 lower-hex characters.
https://github.com/openzipkin/b3-propagation#identifiers

Would be nice if you can support b3 tracing id with 128 bits

@knusbaum
Copy link
Contributor

Related to #695

@gbbr
Copy link
Contributor

gbbr commented Nov 19, 2020

I guess we can close now.

@gbbr gbbr closed this as completed Nov 19, 2020
@stroem
Copy link
Contributor Author

stroem commented Nov 20, 2020

Added issue and PR for supporting for B3 extract for dd-lambda-wrapper: DataDog/datadog-lambda-go#50 (@gbbr, would you like to take a look at it?)

That issue depends on this one. Would be nice if dd-trace/tracer repo can be bumped to make use of this fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants