Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/Shopify/sarama: use sarama.MinVersion in tests. #761

Merged
merged 1 commit into from
Oct 15, 2020

Commits on Oct 14, 2020

  1. contrib/Shopify/sarama: use sarama.MinVersion in tests.

    Starting in github.com/Shopify/sarama@v1.27.1, the default kafka version
    that the client uses is 1.0.0 (sarama.V1_0_0_0) rather that the previous
    0.8.2 (sarama.V0_8_2_0) Unfortunately, the Sarama client for Kafka 1.0.0
    does not work with the mock broker, so this change breaks our tests. To
    repair the situation, we specify that the client should use version 0.8.2.
    If Sarama fixes their mock client in the future, we can use the default
    version instead.
    knusbaum committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    c75bc53 View commit details
    Browse the repository at this point in the history