contrib/Shopify/sarama: use sarama.MinVersion in tests. #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in github.com/Shopify/sarama@v1.27.1, the default kafka version that the client uses is 1.0.0 (sarama.V1_0_0_0) rather that the previous 0.8.2 (sarama.V0_8_2_0) Unfortunately, the Sarama client for Kafka 1.0.0 does not work with the mock broker, so this change breaks our tests. To repair the situation, we specify that the client should use version 0.8.2. If Sarama fixes their mock client in the future, we can use the default version instead.
gbbr
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in github.com/Shopify/sarama@v1.27.1, the default kafka version
that the client uses is 1.0.0 (sarama.V1_0_0_0) rather that the previous
0.8.2 (sarama.V0_8_2_0) Unfortunately, the Sarama client for Kafka 1.0.0
does not work with the mock broker, so this change breaks our tests. To
repair the situation, we specify that the client should use version 0.8.2.
If Sarama fixes their mock client in the future, we can use the default
version instead.