ddtrace/tracer: add service version to tracer. #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es DD_SERVICE and DD_VERSION.
|
This is massively confusing from an API standpoint. Not exactly sure what we're doing here (no PR description provided), but let's not do it like this. |
gbbr
suggested changes
Mar 11, 2020
There was a problem hiding this comment.
Is "service name" and "service" supposed to be the same thing? If yes, let's make sure that only one of them exists from a user standpoint. For example: change ext.ServiceName to have the value "service" but keep support for "service.name" to make sure there are no breaking changes for people using this string direclty.
knusbaum
commented
Mar 12, 2020
gbbr
reviewed
Mar 13, 2020
knusbaum
changed the title
gbbr
reviewed
Mar 13, 2020
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
This commit adds the concept of a service version to the tracer. The service version should be the current version of the application (service). the service version will be picked up from the DD_VERSION environment variable, or can be set with the WithServiceVersion StartOption when starting the tracer. WithServiceVersion takes priority over the environment variable. Spans that have a service name equal to the application's service name (set with DD_SERVICE or the WithServiceName StartOption) will be given a "version" tag with the service version as its value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the concept of a service version to the tracer. The service version should be the current version of the application (service). the service version will be picked up from the
DD_VERSIONenvironment variable, or can be set with theWithServiceVersionStartOptionwhen starting the tracer.WithServiceVersiontakes priority over the environment variable.Spans that have a service name equal to the application's service name (set with
DD_SERVICEor theWithServiceNameStartOption) will be given a"version"tag with the service version as its value.