Skip to content

Commit

Permalink
Remove unnecessary test
Browse files Browse the repository at this point in the history
  • Loading branch information
knusbaum committed Mar 16, 2020
1 parent 17c972d commit 180b773
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions ddtrace/tracer/tracer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1068,22 +1068,6 @@ func TestVersion(t *testing.T) {
_, ok := sp.Meta[ext.Version]
assert.False(ok)
})

t.Run("unset3", func(t *testing.T) {
os.Setenv("DD_SERVICE", "servenv")
defer os.Unsetenv("DD_SERVICE")
os.Setenv("DD_VERSION", "1.2.3")
defer os.Unsetenv("DD_VERSION")

// WithGlobalTag sets ext.ServiceName on each individual span, so version will not be set.
tracer, _, _, stop := startTestTracer(t, WithGlobalTag(ext.ServiceName, "otherservenv"))
defer stop()

assert := assert.New(t)
sp := tracer.StartSpan("http.request").(*span)
_, ok := sp.Meta[ext.Version]
assert.False(ok)
})
}

// BenchmarkConcurrentTracing tests the performance of spawning a lot of
Expand Down

0 comments on commit 180b773

Please sign in to comment.