Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiler: fix race in TestProfilerPassthrough #601

Merged
merged 4 commits into from
Mar 2, 2020
Merged

profiler: fix race in TestProfilerPassthrough #601

merged 4 commits into from
Mar 2, 2020

Commits on Feb 26, 2020

  1. profiler: fix race in TestProfilerPassthrough 

    The test previously was trying to read from the p.out channel, which was racing against the send() function and uploadFunc

This patch makes the test read from the correct out channel and eliminates an unnecessary loop.
    @knusbaum
    knusbaum committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    2ed08f7 View commit details
    Browse the repository at this point in the history

  2. increase timeout for passthrough.

    @knusbaum
    knusbaum committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    a0a1c7f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'v1' into knusbaum/improve_profiler_test

    @knusbaum
    knusbaum authored Feb 26, 2020
    Configuration menu
    Copy the full SHA
    b10954f View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. Add todo for profiler timeout.

    @knusbaum
    knusbaum committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    d4596a6 View commit details
    Browse the repository at this point in the history