profiler: fix race in TestProfilerPassthrough #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knusbaum
changed the title
The test previously was trying to read from the p.out channel, which was racing against the send() function and uploadFunc This patch makes the test read from the correct out channel and eliminates an unnecessary loop.
knusbaum
force-pushed
the
knusbaum/improve_profiler_test
branch
from
9fc8171
to
2ed08f7
Compare
|
This doesn't fix it. |
|
@cgilmour I increased the timeout. Please let me know if you're still seeing failures. It would be ideal to eliminate the time dependency of this test altogether, but that's a larger change and I don't want to block other PRs on it. |
cgilmour
previously approved these changes
Feb 27, 2020
cgilmour
approved these changes
Mar 2, 2020
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
The test previously was trying to read from the p.out channel, which was racing against the send() function and uploadFunc This patch makes the test read from the correct out channel and eliminates an unnecessary loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CircleCI the TestProfilerPassthrough test seems to be flaky and run into the
"time expired"failure frequently.The test previously was trying to read from the
p.outchannel, which was racing against thesend()function anduploadFuncThis patch makes the test read from the correct
outchannel and eliminates an unnecessary loop.