profiler: randomize wait duration before retrying upload #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #827 introduced a randomized wait duration before retrying a failed profile upload. This was done to reduce the likelihood of flooding the backend with uploads. The wait was done to be an average of half the profiling perdio. However, PR #961 lost this behavior when introducing interruptible sleeps. This commit restores the lost behavior. Fixes #1395
Kyle-Verhoog
pushed a commit
that referenced
this pull request
Jul 21, 2022
PR #827 introduced a randomized wait duration before retrying a failed profile upload. This was done to reduce the likelihood of flooding the backend with uploads. The wait was done to be an average of half the profiling perdio. However, PR #961 lost this behavior when introducing interruptible sleeps. This commit restores the lost behavior. Fixes #1395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #827 introduced a randomized wait duration before retrying a failed
profile upload. This was done to reduce the likelihood of flooding the
backend with uploads. The wait was done to be an average of half the
profiling perdio. However, PR #961 lost this behavior when introducing
interruptible sleeps. This commit restores the lost behavior.
Fixes #1395