-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiler upload does always wait a second before retrying upload #1395
Comments
sumerc
changed the title
profiler upload does not wait before retrying upload
profiler upload does always wait a second before retrying upload
Jul 21, 2022
nsrip-dd
added a commit
that referenced
this issue
Jul 21, 2022
PR #827 introduced a randomized wait duration before retrying a failed profile upload. This was done to reduce the likelihood of flooding the backend with uploads. The wait was done to be an average of half the profiling perdio. However, PR #961 lost this behavior when introducing interruptible sleeps. This commit restores the lost behavior. Fixes #1395
nsrip-dd
added a commit
that referenced
this issue
Jul 21, 2022
PR #827 introduced a randomized wait duration before retrying a failed profile upload. This was done to reduce the likelihood of flooding the backend with uploads. The wait was done to be an average of half the profiling perdio. However, PR #961 lost this behavior when introducing interruptible sleeps. This commit restores the lost behavior. Fixes #1395
Kyle-Verhoog
pushed a commit
that referenced
this issue
Jul 21, 2022
PR #827 introduced a randomized wait duration before retrying a failed profile upload. This was done to reduce the likelihood of flooding the backend with uploads. The wait was done to be an average of half the profiling perdio. However, PR #961 lost this behavior when introducing interruptible sleeps. This commit restores the lost behavior. Fixes #1395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Interestingly, I have spotted this while I was reading the code below:
It seems that
wait
is not used anywhere. I think the line should be following?The text was updated successfully, but these errors were encountered: