Skip to content

Commit

Permalink
move BoolEnv to internal package, remove boolEnv from ddtrace/tracer,…
Browse files Browse the repository at this point in the history
… use internal.BoolEnv.
  • Loading branch information
knusbaum committed Jul 21, 2020
1 parent 2d12786 commit 1b10a40
Show file tree
Hide file tree
Showing 33 changed files with 81 additions and 73 deletions.
3 changes: 2 additions & 1 deletion contrib/Shopify/sarama/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ package sarama
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal"
"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
)

Expand All @@ -24,7 +25,7 @@ func defaults(cfg *config) {
cfg.consumerServiceName = svc
}
// cfg.analyticsRate = globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_SARAMA_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_SARAMA_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
4 changes: 2 additions & 2 deletions contrib/aws/aws-sdk-go/aws/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package aws
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
)

type config struct {
Expand All @@ -21,7 +21,7 @@ type Option func(*config)

func defaults(cfg *config) {
// cfg.analyticsRate = globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_AWS_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_AWS_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
4 changes: 2 additions & 2 deletions contrib/bradfitz/gomemcache/memcache/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package memcache
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
)

const (
Expand All @@ -27,7 +27,7 @@ type ClientOption func(*clientConfig)
func defaults(cfg *clientConfig) {
cfg.serviceName = serviceName
// cfg.analyticsRate = globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_MEMCACHE_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_MEMCACHE_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
3 changes: 2 additions & 1 deletion contrib/confluentinc/confluent-kafka-go/kafka/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"context"
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal"
"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
)

Expand All @@ -30,7 +31,7 @@ func newConfig(opts ...Option) *config {
// analyticsRate: globalconfig.AnalyticsRate(),
analyticsRate: math.NaN(),
}
if globalconfig.BoolEnv("DD_TRACE_KAFKA_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_KAFKA_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
}
if svc := globalconfig.ServiceName(); svc != "" {
Expand Down
4 changes: 2 additions & 2 deletions contrib/database/sql/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package sql
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
)

type config struct {
Expand All @@ -28,7 +28,7 @@ type RegisterOption = Option
func defaults(cfg *config) {
// default cfg.serviceName set in Register based on driver name
// cfg.analyticsRate = globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_SQL_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_SQL_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
3 changes: 2 additions & 1 deletion contrib/emicklei/go-restful/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ package restful
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal"
"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
)

Expand All @@ -18,7 +19,7 @@ type config struct {

func newConfig() *config {
rate := globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_RESTFUL_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_RESTFUL_ANALYTICS_ENABLED", false) {
rate = 1.0
}
return &config{
Expand Down
4 changes: 2 additions & 2 deletions contrib/garyburd/redigo/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package redigo // import "gopkg.in/DataDog/dd-trace-go.v1/contrib/garyburd/redig
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
)

type dialConfig struct {
Expand All @@ -22,7 +22,7 @@ type DialOption func(*dialConfig)
func defaults(cfg *dialConfig) {
cfg.serviceName = "redis.conn"
// cfg.analyticsRate = globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_REDIGO_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_REDIGO_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
3 changes: 2 additions & 1 deletion contrib/gin-gonic/gin/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"net/http"

"github.com/gin-gonic/gin"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
)

Expand All @@ -20,7 +21,7 @@ type config struct {

func newConfig() *config {
rate := globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_GIN_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_GIN_ANALYTICS_ENABLED", false) {
rate = 1.0
}
return &config{
Expand Down
4 changes: 2 additions & 2 deletions contrib/globalsign/mgo/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"context"
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
)

type mongoConfig struct {
Expand All @@ -20,7 +20,7 @@ type mongoConfig struct {

func newConfig() *mongoConfig {
rate := math.NaN()
if globalconfig.BoolEnv("DD_TRACE_GIN_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_GIN_ANALYTICS_ENABLED", false) {
rate = 1.0
}
return &mongoConfig{
Expand Down
3 changes: 2 additions & 1 deletion contrib/go-chi/chi/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/ddtrace"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
)

Expand All @@ -26,7 +27,7 @@ func defaults(cfg *config) {
if svc := globalconfig.ServiceName(); svc != "" {
cfg.serviceName = svc
}
if globalconfig.BoolEnv("DD_TRACE_CHI_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_CHI_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = globalconfig.AnalyticsRate()
Expand Down
4 changes: 2 additions & 2 deletions contrib/go-redis/redis/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package redis // import "gopkg.in/DataDog/dd-trace-go.v1/contrib/go-redis/redis"
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
)

type clientConfig struct {
Expand All @@ -22,7 +22,7 @@ type ClientOption func(*clientConfig)
func defaults(cfg *clientConfig) {
cfg.serviceName = "redis.client"
// cfg.analyticsRate = globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_REDIS_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_REDIS_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
4 changes: 2 additions & 2 deletions contrib/go.mongodb.org/mongo-driver/mongo/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package mongo
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
)

type config struct {
Expand All @@ -22,7 +22,7 @@ type Option func(*config)
func defaults(cfg *config) {
cfg.serviceName = "mongo"
// cfg.analyticsRate = globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_MONGO_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_MONGO_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
4 changes: 2 additions & 2 deletions contrib/gocql/gocql/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package gocql
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
)

type queryConfig struct {
Expand All @@ -23,7 +23,7 @@ type WrapOption func(*queryConfig)
func defaults(cfg *queryConfig) {
cfg.serviceName = "gocql.query"
// cfg.analyticsRate = globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_GOCQL_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_GOCQL_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
4 changes: 2 additions & 2 deletions contrib/gomodule/redigo/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package redigo // import "gopkg.in/DataDog/dd-trace-go.v1/contrib/gomodule/redig
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
)

type dialConfig struct {
Expand All @@ -22,7 +22,7 @@ type DialOption func(*dialConfig)
func defaults(cfg *dialConfig) {
cfg.serviceName = "redis.conn"
// cfg.analyticsRate = globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_REDIGO_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_REDIGO_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
4 changes: 2 additions & 2 deletions contrib/google.golang.org/api/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"context"
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
)

type config struct {
Expand All @@ -21,7 +21,7 @@ type config struct {

func newConfig(options ...Option) *config {
rate := math.NaN()
if globalconfig.BoolEnv("DD_TRACE_GOOGLE_API_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_GOOGLE_API_ANALYTICS_ENABLED", false) {
rate = 1.0
}
cfg := &config{
Expand Down
4 changes: 2 additions & 2 deletions contrib/google.golang.org/grpc.v12/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package grpc
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
)

type interceptorConfig struct {
Expand All @@ -23,7 +23,7 @@ type InterceptorOption func(*interceptorConfig)
func defaults(cfg *interceptorConfig) {
// cfg.serviceName default set in interceptor
// cfg.analyticsRate = globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_GRPC_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_GRPC_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
3 changes: 2 additions & 1 deletion contrib/google.golang.org/grpc/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ package grpc
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal"
"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"

"google.golang.org/grpc/codes"
Expand Down Expand Up @@ -58,7 +59,7 @@ func defaults(cfg *config) {
cfg.traceStreamMessages = true
cfg.nonErrorCodes = map[codes.Code]bool{codes.Canceled: true}
// cfg.analyticsRate = globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_GRPC_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_GRPC_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
3 changes: 2 additions & 1 deletion contrib/gorilla/mux/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (

"gopkg.in/DataDog/dd-trace-go.v1/ddtrace"
"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
)

Expand All @@ -26,7 +27,7 @@ type routerConfig struct {
type RouterOption func(*routerConfig)

func defaults(cfg *routerConfig) {
if globalconfig.BoolEnv("DD_TRACE_MUX_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_MUX_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = globalconfig.AnalyticsRate()
Expand Down
3 changes: 2 additions & 1 deletion contrib/graph-gophers/graphql-go/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ package graphql
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal"
"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
)

Expand All @@ -25,7 +26,7 @@ func defaults(cfg *config) {
cfg.serviceName = svc
}
// cfg.analyticsRate = globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_GRAPHQL_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_GRAPHQL_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
4 changes: 2 additions & 2 deletions contrib/hashicorp/consul/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package consul
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
)

const (
Expand All @@ -25,7 +25,7 @@ type ClientOption func(*clientConfig)

func defaults(cfg *clientConfig) {
cfg.serviceName = serviceName
if globalconfig.BoolEnv("DD_TRACE_CONSUL_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_CONSUL_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
3 changes: 2 additions & 1 deletion contrib/hashicorp/vault/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ package vault
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal"
"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
)

Expand All @@ -23,7 +24,7 @@ type Option func(*config)

func defaults(cfg *config) {
cfg.serviceName = defaultServiceName
if globalconfig.BoolEnv("DD_TRACE_VAULT_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_VAULT_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = globalconfig.AnalyticsRate()
Expand Down
4 changes: 2 additions & 2 deletions contrib/jinzhu/gorm/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package gorm
import (
"math"

"gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal"
)

type config struct {
Expand All @@ -23,7 +23,7 @@ type Option func(*config)
func defaults(cfg *config) {
cfg.serviceName = "gorm.db"
// cfg.analyticsRate = globalconfig.AnalyticsRate()
if globalconfig.BoolEnv("DD_TRACE_GORM_ANALYTICS_ENABLED", false) {
if internal.BoolEnv("DD_TRACE_GORM_ANALYTICS_ENABLED", false) {
cfg.analyticsRate = 1.0
} else {
cfg.analyticsRate = math.NaN()
Expand Down
Loading

0 comments on commit 1b10a40

Please sign in to comment.