rename DD_*_ANALYTICS_ENABLED and remove DD_TRACE_ENABLED

DataDog · Jul 21, 2020 · 2d12786 · 2d12786
1 parent 61add9e
commit 2d12786
Show file tree

Hide file tree

Showing 31 changed files with 30 additions and 33 deletions.
diff --git a/contrib/Shopify/sarama/option.go b/contrib/Shopify/sarama/option.go
@@ -24,7 +24,7 @@ func defaults(cfg *config) {
 		cfg.consumerServiceName = svc
 	}
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_SARAMA_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_SARAMA_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/aws/aws-sdk-go/aws/option.go b/contrib/aws/aws-sdk-go/aws/option.go
@@ -21,7 +21,7 @@ type Option func(*config)
 
 func defaults(cfg *config) {
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_AWS_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_AWS_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/bradfitz/gomemcache/memcache/option.go b/contrib/bradfitz/gomemcache/memcache/option.go
@@ -27,7 +27,7 @@ type ClientOption func(*clientConfig)
 func defaults(cfg *clientConfig) {
 	cfg.serviceName = serviceName
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_MEMCACHE_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_MEMCACHE_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/confluentinc/confluent-kafka-go/kafka/option.go b/contrib/confluentinc/confluent-kafka-go/kafka/option.go
@@ -30,7 +30,7 @@ func newConfig(opts ...Option) *config {
 		// analyticsRate: globalconfig.AnalyticsRate(),
 		analyticsRate: math.NaN(),
 	}
-	if globalconfig.BoolEnv("DD_KAFKA_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_KAFKA_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	}
 	if svc := globalconfig.ServiceName(); svc != "" {

diff --git a/contrib/database/sql/option.go b/contrib/database/sql/option.go
@@ -28,7 +28,7 @@ type RegisterOption = Option
 func defaults(cfg *config) {
 	// default cfg.serviceName set in Register based on driver name
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_SQL_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_SQL_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/emicklei/go-restful/option.go b/contrib/emicklei/go-restful/option.go
@@ -18,7 +18,7 @@ type config struct {
 
 func newConfig() *config {
 	rate := globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_RESTFUL_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_RESTFUL_ANALYTICS_ENABLED", false) {
 		rate = 1.0
 	}
 	return &config{

diff --git a/contrib/garyburd/redigo/option.go b/contrib/garyburd/redigo/option.go
@@ -22,7 +22,7 @@ type DialOption func(*dialConfig)
 func defaults(cfg *dialConfig) {
 	cfg.serviceName = "redis.conn"
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_REDIGO_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_REDIGO_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/gin-gonic/gin/option.go b/contrib/gin-gonic/gin/option.go
@@ -20,7 +20,7 @@ type config struct {
 
 func newConfig() *config {
 	rate := globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_GIN_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_GIN_ANALYTICS_ENABLED", false) {
 		rate = 1.0
 	}
 	return &config{

diff --git a/contrib/globalsign/mgo/option.go b/contrib/globalsign/mgo/option.go
@@ -20,7 +20,7 @@ type mongoConfig struct {
 
 func newConfig() *mongoConfig {
 	rate := math.NaN()
-	if globalconfig.BoolEnv("DD_GIN_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_GIN_ANALYTICS_ENABLED", false) {
 		rate = 1.0
 	}
 	return &mongoConfig{

diff --git a/contrib/go-chi/chi/option.go b/contrib/go-chi/chi/option.go
@@ -26,7 +26,7 @@ func defaults(cfg *config) {
 	if svc := globalconfig.ServiceName(); svc != "" {
 		cfg.serviceName = svc
 	}
-	if globalconfig.BoolEnv("DD_CHI_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_CHI_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = globalconfig.AnalyticsRate()

diff --git a/contrib/go-redis/redis/option.go b/contrib/go-redis/redis/option.go
@@ -22,7 +22,7 @@ type ClientOption func(*clientConfig)
 func defaults(cfg *clientConfig) {
 	cfg.serviceName = "redis.client"
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_REDIS_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_REDIS_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/go.mongodb.org/mongo-driver/mongo/option.go b/contrib/go.mongodb.org/mongo-driver/mongo/option.go
@@ -22,7 +22,7 @@ type Option func(*config)
 func defaults(cfg *config) {
 	cfg.serviceName = "mongo"
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_MONGO_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_MONGO_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/gocql/gocql/option.go b/contrib/gocql/gocql/option.go
@@ -23,7 +23,7 @@ type WrapOption func(*queryConfig)
 func defaults(cfg *queryConfig) {
 	cfg.serviceName = "gocql.query"
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_GOCQL_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_GOCQL_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/gomodule/redigo/option.go b/contrib/gomodule/redigo/option.go
@@ -22,7 +22,7 @@ type DialOption func(*dialConfig)
 func defaults(cfg *dialConfig) {
 	cfg.serviceName = "redis.conn"
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_REDIGO_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_REDIGO_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/google.golang.org/api/option.go b/contrib/google.golang.org/api/option.go
@@ -21,7 +21,7 @@ type config struct {
 
 func newConfig(options ...Option) *config {
 	rate := math.NaN()
-	if globalconfig.BoolEnv("DD_GOOGLE_API_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_GOOGLE_API_ANALYTICS_ENABLED", false) {
 		rate = 1.0
 	}
 	cfg := &config{

diff --git a/contrib/google.golang.org/grpc.v12/option.go b/contrib/google.golang.org/grpc.v12/option.go
@@ -23,7 +23,7 @@ type InterceptorOption func(*interceptorConfig)
 func defaults(cfg *interceptorConfig) {
 	// cfg.serviceName default set in interceptor
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_GRPC_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_GRPC_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/google.golang.org/grpc/option.go b/contrib/google.golang.org/grpc/option.go
@@ -58,7 +58,7 @@ func defaults(cfg *config) {
 	cfg.traceStreamMessages = true
 	cfg.nonErrorCodes = map[codes.Code]bool{codes.Canceled: true}
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_GRPC_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_GRPC_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/gorilla/mux/option.go b/contrib/gorilla/mux/option.go
@@ -26,7 +26,7 @@ type routerConfig struct {
 type RouterOption func(*routerConfig)
 
 func defaults(cfg *routerConfig) {
-	if globalconfig.BoolEnv("DD_MUX_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_MUX_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = globalconfig.AnalyticsRate()

diff --git a/contrib/graph-gophers/graphql-go/option.go b/contrib/graph-gophers/graphql-go/option.go
@@ -25,7 +25,7 @@ func defaults(cfg *config) {
 		cfg.serviceName = svc
 	}
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_GRAPHQL_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_GRAPHQL_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/hashicorp/consul/option.go b/contrib/hashicorp/consul/option.go
@@ -25,7 +25,7 @@ type ClientOption func(*clientConfig)
 
 func defaults(cfg *clientConfig) {
 	cfg.serviceName = serviceName
-	if globalconfig.BoolEnv("DD_CONSUL_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_CONSUL_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/hashicorp/vault/option.go b/contrib/hashicorp/vault/option.go
@@ -23,7 +23,7 @@ type Option func(*config)
 
 func defaults(cfg *config) {
 	cfg.serviceName = defaultServiceName
-	if globalconfig.BoolEnv("DD_VAULT_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_VAULT_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = globalconfig.AnalyticsRate()

diff --git a/contrib/jinzhu/gorm/option.go b/contrib/jinzhu/gorm/option.go
@@ -23,7 +23,7 @@ type Option func(*config)
 func defaults(cfg *config) {
 	cfg.serviceName = "gorm.db"
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_GORM_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_GORM_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/julienschmidt/httprouter/option.go b/contrib/julienschmidt/httprouter/option.go
@@ -22,7 +22,7 @@ type routerConfig struct {
 type RouterOption func(*routerConfig)
 
 func defaults(cfg *routerConfig) {
-	if globalconfig.BoolEnv("DD_HTTPROUTER_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_HTTPROUTER_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = globalconfig.AnalyticsRate()

diff --git a/contrib/labstack/echo/option.go b/contrib/labstack/echo/option.go
@@ -24,7 +24,7 @@ func defaults(cfg *config) {
 	if svc := globalconfig.ServiceName(); svc != "" {
 		cfg.serviceName = svc
 	}
-	if globalconfig.BoolEnv("DD_ECHO_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_ECHO_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/net/http/option.go b/contrib/net/http/option.go
@@ -29,7 +29,7 @@ type MuxOption = Option
 type Option func(*config)
 
 func defaults(cfg *config) {
-	if globalconfig.BoolEnv("DD_HTTP_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_HTTP_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = globalconfig.AnalyticsRate()

diff --git a/contrib/olivere/elastic/option.go b/contrib/olivere/elastic/option.go
@@ -27,7 +27,7 @@ func defaults(cfg *clientConfig) {
 	cfg.transport = http.DefaultTransport.(*http.Transport)
 	cfg.resourceNamer = quantize
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_ELASTIC_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_ELASTIC_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/syndtr/goleveldb/leveldb/option.go b/contrib/syndtr/goleveldb/leveldb/option.go
@@ -25,7 +25,7 @@ func newConfig(opts ...Option) *config {
 		// cfg.analyticsRate: globalconfig.AnalyticsRate(),
 		analyticsRate: math.NaN(),
 	}
-	if globalconfig.BoolEnv("DD_LEVELDB_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_LEVELDB_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	}
 	for _, opt := range opts {

diff --git a/contrib/tidwall/buntdb/option.go b/contrib/tidwall/buntdb/option.go
@@ -22,7 +22,7 @@ func defaults(cfg *config) {
 	cfg.serviceName = "buntdb"
 	cfg.ctx = context.Background()
 	// cfg.analyticsRate = globalconfig.AnalyticsRate()
-	if globalconfig.BoolEnv("DD_BUNTDB_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_BUNTDB_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = math.NaN()

diff --git a/contrib/twitchtv/twirp/option.go b/contrib/twitchtv/twirp/option.go
@@ -20,7 +20,7 @@ type config struct {
 type Option func(*config)
 
 func defaults(cfg *config) {
-	if globalconfig.BoolEnv("DD_TWIRP_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_TWIRP_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = globalconfig.AnalyticsRate()

diff --git a/contrib/zenazn/goji.v1/web/option.go b/contrib/zenazn/goji.v1/web/option.go
@@ -24,7 +24,7 @@ type config struct {
 type Option func(*config)
 
 func defaults(cfg *config) {
-	if globalconfig.BoolEnv("DD_GOJI_ANALYTICS_ENABLED", false) {
+	if globalconfig.BoolEnv("DD_TRACE_GOJI_ANALYTICS_ENABLED", false) {
 		cfg.analyticsRate = 1.0
 	} else {
 		cfg.analyticsRate = globalconfig.AnalyticsRate()

diff --git a/ddtrace/tracer/tracer.go b/ddtrace/tracer/tracer.go
@@ -91,9 +91,6 @@ func Start(opts ...StartOption) {
 	if internal.Testing {
 		return // mock tracer active
 	}
-	if !boolEnv("DD_TRACE_ENABLED", true) {
-		return
-	}
 	t := newTracer(opts...)
 	internal.SetGlobalTracer(t)
 	if t.config.logStartup {