Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorting the symbol extractor tests approval names #5079

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

dudikeleti
Copy link
Contributor

Summary of changes

Shorting the symbol extractor tests approval names

Reason for change

Too long file path breaks the gitlab build

@dudikeleti dudikeleti requested a review from a team as a code owner January 18, 2024 11:36
@github-actions github-actions bot added the area:tests unit tests, integration tests label Jan 18, 2024
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dudikeleti dudikeleti force-pushed the dudik/shorting-approval-names branch from 57aba60 to 2f66500 Compare January 18, 2024 12:09
Copy link
Contributor

@GreenMatan GreenMatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 18, 2024

Datadog Report

Branch report: dudik/shorting-approval-names
Commit report: 2f66500
Test service: dd-trace-dotnet

✅ 0 Failed, 304272 Passed, 1502 Skipped, 25m 15.86s Wall Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5079) - mean (71ms)  : 62, 80
     .   : milestone, 71,
    master - mean (73ms)  : 63, 84
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5079) - mean (961ms)  : 946, 976
     .   : milestone, 961,
    master - mean (1,028ms)  : 1003, 1053
     .   : milestone, 1028,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5079) - mean (106ms)  : 104, 109
     .   : milestone, 106,
    master - mean (106ms)  : 102, 110
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (5079) - mean (703ms)  : 680, 726
     .   : milestone, 703,
    master - mean (731ms)  : 714, 748
     .   : milestone, 731,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5079) - mean (91ms)  : 88, 94
     .   : milestone, 91,
    master - mean (90ms)  : 87, 93
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (5079) - mean (659ms)  : 638, 681
     .   : milestone, 659,
    master - mean (693ms)  : 669, 716
     .   : milestone, 693,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5079) - mean (189ms)  : 187, 191
     .   : milestone, 189,
    master - mean (189ms)  : 185, 192
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (5079) - mean (1,066ms)  : 1044, 1088
     .   : milestone, 1066,
    master - mean (1,135ms)  : 1117, 1154
     .   : milestone, 1135,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5079) - mean (272ms)  : 269, 275
     .   : milestone, 272,
    master - mean (272ms)  : 267, 277
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (5079) - mean (1,050ms)  : 1021, 1079
     .   : milestone, 1050,
    master - mean (1,086ms)  : 1064, 1109
     .   : milestone, 1086,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5079) - mean (262ms)  : 258, 265
     .   : milestone, 262,
    master - mean (261ms)  : 258, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (5079) - mean (1,022ms)  : 989, 1055
     .   : milestone, 1022,
    master - mean (1,053ms)  : 1033, 1073
     .   : milestone, 1053,

Loading

@andrewlock andrewlock merged commit 0c3aae1 into master Jan 18, 2024
50 of 55 checks passed
@andrewlock andrewlock deleted the dudik/shorting-approval-names branch January 18, 2024 14:24
@github-actions github-actions bot added this to the vNext milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests unit tests, integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants