Skip to content

Commit

Permalink
Shorting the symbol extractor tests approval names
Browse files Browse the repository at this point in the history
  • Loading branch information
@dudikeleti
dudikeleti committed Jan 18, 2024
1 parent a0379fe commit 57aba60
Show file tree
Hide file tree
Showing 22 changed files with 23 additions and 239 deletions.
2 changes: 1 addition & 1 deletion ...ests.TestSamples.AsyncMethod.verified.txt → ...bolExtractorTest.AsyncMethod.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...ComprehensiveLinqWithClosure.verified.txt → ...ComprehensiveLinqWithClosure.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...prehensiveLinqWithoutClosure.verified.txt → ...prehensiveLinqWithoutClosure.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
216 changes: 0 additions & 216 deletions ....Trace.Tests.Debugger.SymbolsTests.TestSamples.HoistedLocalsMultipleClosures.verified.txt
View file

This file was deleted.

2 changes: 1 addition & 1 deletion ...sTests.TestSamples.EmptyType.verified.txt → ...ymbolExtractorTest.EmptyType.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...s.HoistedAndNotHoistedLocals.verified.txt → ...t.HoistedAndNotHoistedLocals.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
0 ...dLocalsAndArgsInStateMachine.verified.txt → ...dLocalsAndArgsInStateMachine.verified.txt
View file
File renamed without changes.
2 changes: 1 addition & 1 deletion ...estSamples.LambdaWithClosure.verified.txt → ...ractorTest.LambdaWithClosure.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...mples.LambdaWithFieldClosure.verified.txt → ...rTest.LambdaWithFieldClosure.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...LambdaWithStaticFieldClosure.verified.txt → ...LambdaWithStaticFieldClosure.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...Samples.LambdaWithoutClosure.verified.txt → ...torTest.LambdaWithoutClosure.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...s.TestSamples.LocalConstants.verified.txt → ...ExtractorTest.LocalConstants.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...les.LocalFunctionWithClosure.verified.txt → ...est.LocalFunctionWithClosure.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ....LocalFunctionWithoutClosure.verified.txt → ....LocalFunctionWithoutClosure.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...tipleClosuresMultipleHoisted.verified.txt → ...tipleClosuresMultipleHoisted.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...amples.MultipleHoistedLocals.verified.txt → ...orTest.MultipleHoistedLocals.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...eHoistedLocalsInStateMachine.verified.txt → ...eHoistedLocalsInStateMachine.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...s.TestSamples.MultipleScopes.verified.txt → ...ExtractorTest.MultipleScopes.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...TestSamples.NestedFluentLinq.verified.txt → ...tractorTest.NestedFluentLinq.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ...sts.TestSamples.PartialClass.verified.txt → ...olExtractorTest.PartialClass.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
2 changes: 1 addition & 1 deletion ....SameLocalNameDifferentScope.verified.txt → ....SameLocalNameDifferentScope.verified.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"service": "test",
"env": "test",
"version": "0",
Expand Down
8 changes: 4 additions & 4 deletions tracer/test/Datadog.Trace.Tests/Debugger/SymbolsTests/SymbolExtractorTest.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ private async Task Test(Type type)
Assert.True(root.Scopes.Count == 1);
Assert.True(root.Scopes.First().Scopes.Length == 1);
Assert.True(root.Scopes.First().Scopes.First().Name == type.FullName);
var settings = ConfigureVerifySettings(assembly.GetName().Name, type.FullName);
var settings = ConfigureVerifySettings(type.Name);
var toVerify = GetStringToVerify(root);
await Verifier.Verify(toVerify, settings);
}
Expand All @@ -62,7 +62,7 @@ private async Task TestDnlib(Type type)
Assert.True(root.Scopes.Count == 1);
Assert.True(root.Scopes.First().Scopes.Length == 1);
Assert.True(root.Scopes.First().Scopes.First().Name == type.FullName);
var settings = ConfigureVerifySettings(assembly.GetName().Name, type.FullName);
var settings = ConfigureVerifySettings(type.Name);
var toVerify = GetStringToVerify(root);
await Verifier.Verify(toVerify, settings);
}
Expand Down Expand Up @@ -143,10 +143,10 @@ void SanitizeScopeToVerify(ref Trace.Debugger.Symbols.Model.Scope scope)
}
}

private VerifySettings ConfigureVerifySettings(string assemblyName, string className)
private VerifySettings ConfigureVerifySettings(string className)
{
var settings = new VerifySettings();
settings.UseFileName($"{nameof(SymbolExtractorTest)}.{assemblyName}.{className}");
settings.UseFileName($"{nameof(SymbolExtractorTest)}.{className}");
settings.DisableRequireUniquePrefix();
settings.UseDirectory("SymbolExtractor/Approvals");
return settings;
Expand Down

0 comments on commit 57aba60

Please sign in to comment.