-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak GitLab jobs #4453
Tweak GitLab jobs #4453
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,7 @@ build: | |
except: | ||
variables: | ||
- $DEPLOY_TO_REL_ENV == "true" | ||
- $CI_COMMIT_TAG # We don't need to build/publish when building a release tag | ||
stage: build | ||
tags: ["runner:windows-docker", "windowsversion:1809"] | ||
script: | ||
|
@@ -60,6 +61,7 @@ publish: | |
except: | ||
variables: | ||
- $DEPLOY_TO_REL_ENV == "true" | ||
- $CI_COMMIT_TAG # We don't need to build/publish when building a release tag | ||
stage: publish | ||
tags: ["runner:windows-docker", "windowsversion:1809"] | ||
dependencies: | ||
|
@@ -196,7 +198,8 @@ package: | |
- if: $DOTNET_PACKAGE_VERSION | ||
when: on_success | ||
- if: '$CI_COMMIT_TAG =~ /^v[0-9]+\.[0-9]+\.[0-9]+(-prerelease)?$/' | ||
when: on_success | ||
when: manual | ||
allow_failure: false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's independent from previous job and as it's manual, I assume we could leave There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As discussed offline, I don't think so, because that makes the job "fire and forget", whereas we require this stage to pass for subsequent stages to run |
||
script: | ||
- ../.gitlab/build-deb-rpm.sh | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think it's needed as the only lists only branches so it will run only for pipeline for a branch (cf the doc).
And I think you should set
tags
here per the docThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, as discussed it's probably fine. But when running manually, and you set
$CI_COMMIT_TAG
, I don't think we want to run this stage, right? Andtags
wouldn't help us then, whereas it does in this situation 🤔