Tweak GitLab jobs #4453
Tweak GitLab jobs #4453
Conversation
- No need to build/publish tracer when building the Tag (triggered by a release) - Manually trigger the package job (so we can do it in our own time instead of having a deadline
andrewlock
added
the
area:builds
| @@ -196,7 +198,8 @@ package: | |||
| - if: $DOTNET_PACKAGE_VERSION | |||
| when: on_success | |||
| - if: '$CI_COMMIT_TAG =~ /^v[0-9]+\.[0-9]+\.[0-9]+(-prerelease)?$/' | |||
| when: on_success | |||
| when: manual | |||
| allow_failure: false | |||
There was a problem hiding this comment.
it's independent from previous job and as it's manual, I assume we could leave alllow_failure:true
There was a problem hiding this comment.
As discussed offline, I don't think so, because that makes the job "fire and forget", whereas we require this stage to pass for subsequent stages to run
| @@ -60,6 +61,7 @@ publish: | |||
| except: | |||
| variables: | |||
| - $DEPLOY_TO_REL_ENV == "true" | |||
| - $CI_COMMIT_TAG # We don't need to build/publish when building a release tag | |||
There was a problem hiding this comment.
Don't think it's needed as the only lists only branches so it will run only for pipeline for a branch (cf the doc).
And I think you should set tags here per the doc
There was a problem hiding this comment.
Yeah, as discussed it's probably fine. But when running manually, and you set $CI_COMMIT_TAG, I don't think we want to run this stage, right? And tags wouldn't help us then, whereas it does in this situation 🤔
Summary of changes
packagejob (so we can do it in our own time instead of having a deadlineReason for change
As part of the draft release process, the GitHub Action creates a
git tag. Pushing this tag in turn triggers the GitLab build. However, thepackagestage in the GitLab build currently requires that the release is already published. This therefore creates a deadline for publishing a draft release, which we don't want.Additionally, the stages in the GitLab pipeline that run on the tag, don't rely on the
buildorpublishstages (as they're get their assets from other places). We can therefore skip these steps (as they take a long time, and block the running of subsequent stages that we do care about)Implementation details
exceptclause tobuildandpublishstagespackagestage manually triggeredTest coverage
No 😬
Other details
I hope this does what I think it does. And I hope that skipping the
buildandpublishstages doesn't affect our ability to run the latter stages. I guess we'll find out..