Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automate Layer Releases with R2R artifacts #6

Merged
merged 67 commits into from
Sep 6, 2024

Conversation

duncanista
Copy link
Contributor

@duncanista duncanista commented Sep 3, 2024

What does this PR do?

Automates releases for .NET layer, inspired by the same approach done in DataDog/datadog-lambda-extension#295

Motivation

5508 and #5

Testing Guidelines

  • Deployed manually for sandbox and "prod" like test in sandbox with signing.
  • Tested AWS Lambdas manually.
  • Self Monitoring is already working with an automated release of this.

Additional Notes

Requires DataDog/dd-trace-dotnet#5962 to be merged, so R2R binaries are downloaded.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@duncanista duncanista requested a review from a team as a code owner September 3, 2024 18:00
Comment on lines +12 to +13
RUN apt-get update && \
apt-get install -y zip curl

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Quality Violation

package curl should have version pinned (...read more)

When using apt-get install, pin the version to avoid unwanted upgrades and undefined behavior.

View in Datadog  Leave us feedback  Documentation


TRACER_PROJECT_ID=348

# Clean environment variables if they are set as 'placeholder'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great to wrap some of this code in functions for maintainability!

@duncanista duncanista changed the title feat: add .gitlab-ci.yml feat: Automate Layer Releases with R2R artifacts Sep 5, 2024
@duncanista duncanista merged commit 5ae460b into main Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants