Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate layer releases #93

Closed
wants to merge 2 commits into from

Conversation

nhulston
Copy link

Still work in progress

What does this PR do?

Automates releases for Java layer, inspired by the same approach done in DataDog/datadog-lambda-extension#295 and DataDog/dd-trace-dotnet-aws-lambda-layer#6.

Motivation

https://datadoghq.atlassian.net/browse/SVLS-6086
and we haven't done a release in months.

Testing Guidelines

Todo

Additional Notes

Unlike .NET, we use the same layer regardless of architecture.

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@duncanista duncanista marked this pull request as ready for review December 24, 2024 19:33
@duncanista duncanista requested a review from a team as a code owner December 24, 2024 19:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for us to update and use the pull_and_zip_layers.sh from the scripts/ directory? It will be nice to ensure that any local testing we do uses the same publishing methods as our releases.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking specifically publish_layers.sh, pull_and_zip_layers.sh and sign_layers.sh.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These scripts are different and tailored for GitLab, but after these changes we won't need the old scripts anymore -- we can remove them once I get automated releases working properly

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be nice to keep the others, for publishing to sandbox.

@nhulston
Copy link
Author

@nhulston nhulston closed this Dec 30, 2024
@nhulston nhulston deleted the nicholas.hulston/automate-layer-releases branch December 30, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants