Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-1308: Add more HTTP methods to RUM #1826

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Jan 16, 2024

What does this PR do?

Fixes #1816.

This PR adds support of CONNECT, TRACE, OPTIONS to the RumMonitor#startResource call.

Both RUM resources view and traces/spans created by RUM2APM are working fine for these methods.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners January 16, 2024 10:17
@codecov-commenter
Copy link

Codecov Report

Merging #1826 (2284a01) into develop (7d96d64) will decrease coverage by 0.16%.
Report is 4 commits behind head on develop.
The diff coverage is 81.25%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1826      +/-   ##
===========================================
- Coverage    83.57%   83.41%   -0.16%     
===========================================
  Files          467      467              
  Lines        16462    16442      -20     
  Branches      2480     2475       -5     
===========================================
- Hits         13757    13714      -43     
- Misses        2033     2042       +9     
- Partials       672      686      +14     
Files Coverage Δ
...otlin/com/datadog/android/rum/RumResourceMethod.kt 100.00% <100.00%> (ø)
...g/android/rum/internal/domain/scope/RumEventExt.kt 93.47% <100.00%> (-0.56%) ⬇️
...n/com/datadog/android/okhttp/DatadogInterceptor.kt 73.47% <100.00%> (+0.55%) ⬆️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 84.25% <0.00%> (-0.18%) ⬇️

... and 29 files with indirect coverage changes

@0xnm 0xnm merged commit 8c57aad into develop Jan 17, 2024
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-1308/add-more-http-methods-to-rum branch January 17, 2024 10:21
@xgouchet xgouchet added this to the 2.6.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUM Resources RumResourceMethod enum is missing HTTP request method names
5 participants